Skip to content

logback: log stack trace - #2765

Merged
pongad merged 3 commits into
googleapis:masterfrom
pongad:logging-ex
Jan 22, 2018
Merged

logback: log stack trace#2765
pongad merged 3 commits into
googleapis:masterfrom
pongad:logging-ex

Conversation

@pongad

@pongadpongad commented Jan 11, 2018

Copy link
Copy Markdown
Contributor

Fixes#2735.

@pongad
pongad requested a review from jabubakeJanuary 11, 2018 00:32
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2018
jabubake
jabubake reviewed Jan 11, 2018
View reviewed changes
Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java Outdated
private LogEntry logEntryFor(ILoggingEvent e) {
String payload = e.getFormattedMessage();
StringBuilder payload = new StringBuilder(e.getFormattedMessage());
for (StackTraceElement stackEl : e.getCallerData()) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

jabubake
jabubake previously approved these changes Jan 11, 2018
View reviewed changes

@jabubakejabubake left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

garrettjonesgoogle
garrettjonesgoogle reviewed Jan 11, 2018
View reviewed changes
Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java Outdated
private LogEntry logEntryFor(ILoggingEvent e) {
String payload = e.getFormattedMessage();
StringBuilder payload = new StringBuilder(e.getFormattedMessage());
for (StackTraceElement stackEl : e.getCallerData()) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad

pongad commented Jan 12, 2018

Copy link
Copy Markdown
ContributorAuthor

@jabubake I'm sorry. Looking at this closer, I don't think this is right. The getCallerData returns the trace of the running thread, not of the exception. I don't see a way to get exception trace out of ILoggingEvent. Can you advise?

@jabubake

jabubake commented Jan 12, 2018

Copy link
Copy Markdown
Contributor

ILoggingEvent has a getThrowableProxy method.
see examples here : http://www.javased.com/?api=ch.qos.logback.classic.spi.IThrowableProxy

@jabubake
jabubake dismissed their stale reviewJanuary 12, 2018 16:27

does not log exception as expected

@pongad

pongad commented Jan 15, 2018

Copy link
Copy Markdown
ContributorAuthor

@garrettjonesgoogle@jabubake PTAL. I think this actually works now :)

@pongad

pongad commented Jan 19, 2018

Copy link
Copy Markdown
ContributorAuthor

@garrettjonesgoogle@jabubake Ping

garrettjonesgoogle
garrettjonesgoogle approved these changes Jan 21, 2018
View reviewed changes

@garrettjonesgooglegarrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestion

Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java Outdated
return builder.build();
}

@InternalApi

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java
.append(": ")
.append(throwProxy.getMessage())
.append('\n');
StackTraceElementProxy[] trace = throwProxy.getStackTraceElementProxyArray();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad
pongad merged commit 4ca5d56 into googleapis:masterJan 22, 2018
@pongad
pongad deleted the logging-ex branch January 22, 2018 00:25
@glindstedtglindstedt mentioned this pull request Jan 29, 2018
Closed
@skjolberskjolber mentioned this pull request Mar 13, 2018
Closed
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@pongad
logback: log stack trace (#2765)
b820bf1
Fixes#2735.
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@cloud-java-bot
chore: Update generation configuration at Wed Nov 13 02:24:27 UTC 2024 (
d9f7029
#2765)
* chore: Update generation configuration at Tue Nov 12 02:22:37 UTC 2024
* chore: generate libraries at Tue Nov 12 02:23:19 UTC 2024
* chore: Update generation configuration at Wed Nov 13 02:24:27 UTC 2024
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@pongad
logback: log stack trace (googleapis#2765)
36a03e1
Fixesgoogleapis#2735.
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
@BenWhitehead
fix: update gRPC ReadObject retry to avoid double retry (#2765)
b997288
Prevent adding an unavailable error to the queue if the retrying loop is still active.
Also, cleanup unused retry config for gRPC ReadObject.
rahul2393 pushed a commit to akash329d/google-cloud-java that referenced this pull request May 21, 2026
@renovate-bot
deps: update dependency com.google.cloud:sdk-platform-java-config to …
5972032
…v3.56.0 (googleapis#2765)
This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Adoption](https://docs.renovatebot.com/merge-confidence/) | [Passing](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|---|---|
| [com.google.cloud:sdk-platform-java-config](https://redirect.github.com/googleapis/java-shared-config) | `3.55.1` → `3.56.0` | ![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.cloud:sdk-platform-java-config/3.56.0?slim=true) | ![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.cloud:sdk-platform-java-config/3.56.0?slim=true) | ![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.cloud:sdk-platform-java-config/3.55.1/3.56.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.cloud:sdk-platform-java-config/3.55.1/3.56.0?slim=true) |
| [com.google.cloud:sdk-platform-java-config](https://redirect.github.com/googleapis/java-shared-config) | `3.54.1` → `3.56.0` | ![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.cloud:sdk-platform-java-config/3.56.0?slim=true) | ![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.cloud:sdk-platform-java-config/3.56.0?slim=true) | ![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.cloud:sdk-platform-java-config/3.54.1/3.56.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.cloud:sdk-platform-java-config/3.54.1/3.56.0?slim=true) |
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/java-bigtable).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Mi4xIiwidXBkYXRlZEluVmVyIjoiNDIuOTIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@garrettjonesgooglegarrettjonesgooglegarrettjonesgoogle approved these changes
@jabubakejabubakejabubake left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pongad@jabubake@garrettjonesgoogle@googlebot