resourcemanager: bump dependency version by pongad · Pull Request #2944 · googleapis/google-cloud-java

pongad · 2018-02-23T04:33:36Z

Sign in to view

+ // reference: https://github.com/googleapis/googleapis/blob/master/google/rpc/code.proto
+ switch (status.getCode()) {
+ case 0:
+ code = 200;


Sign in to view

+ private static ResourceManagerException translate(Status status) {
+ int code;
+ // reference: https://github.com/googleapis/googleapis/blob/master/google/rpc/code.proto
+ switch (status.getCode()) {


Sign in to view

+
+ // NOTE(pongad): Operation.getResponse() returns a Map<String, Object>.
+ // `(Project) finishedOp.getResponse()` doesn't work,
+ // because JSON deserializer in execute() didn't know to create a Project object.


pongad · 2018-02-27T03:02:39Z

@vam-google PTAL

Sign in to view

+ .setRetryDelayMultiplier(1.5)
+ // Observed P95 latency is 11s. We probably shouldn't sleep longer than this.
+ .setMaxRetryDelay(Duration.ofSeconds(11))
+ .setJittered(false)


Sign in to view

+ private static final RetrySettings CREATE_RETRY_SETTINGS =
+ RetrySettings.newBuilder()
+ // SLO permits 30s at 90th percentile, double it for total limit
+ .setTotalTimeout(Duration.ofMinutes(1))


Sign in to view

+ RetrySettings.newBuilder()
+ // SLO permits 30s at 90th percentile, double it for total limit
+ .setTotalTimeout(Duration.ofMinutes(1))
+ .setInitialRetryDelay(Duration.ofSeconds(5))


Sign in to view

+ try {
+ return resourceManager.operations().get(operation.getName()).execute();
+ } catch (IOException ex) {
+ throw translate(ex);


Sign in to view

+ @Override
+ public boolean shouldRetry(Throwable prevThrowable, Operation prevOp)
+ throws CancellationException {
+ return prevThrowable != null || prevOp.getDone() == null || !prevOp.getDone();


Sign in to view

+ // 64-bit integers are sent as strings in JSON,
+ // so execute(), not knowing the type, parses it as String, not Long.
+ String responseTxt = JSON_FACTORY.toString(finishedOp.getResponse());
+ return JSON_FACTORY.fromString(responseTxt, Project.class);


Sign in to view


+ private static ResourceManagerException translate(Status status) {
+ int code;
+ if (RPC_TO_HTTP_CODES.containsKey(status.getCode())) {


pongad · 2018-02-28T02:26:52Z

@vam-google PTAL

pongad · 2018-02-28T06:31:37Z

@vam-google PTAL

Sign in to view

+ }
+
+ @Override
+ public boolean shouldRetry(Throwable prevThrowable, Operation prevOp) {


vam-google

LGTM

* deps: update github/codeql-action action to v2.22.2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…onfig to v1.8.1 (#2944) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.8.0` -> `1.8.1` | [![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.cloud:google-cloud-shared-config/1.8.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.cloud:google-cloud-shared-config/1.8.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.cloud:google-cloud-shared-config/1.8.0/1.8.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.cloud:google-cloud-shared-config/1.8.0/1.8.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleapis/java-shared-config (com.google.cloud:google-cloud-shared-config)</summary> ### [`v1.8.1`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#181-2024-06-24) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.8.0...v1.8.1) ##### Dependencies - Update actions/checkout digest to [`692973e`](https://togithub.com/googleapis/java-shared-config/commit/692973e) ([#814](https://togithub.com/googleapis/java-shared-config/issues/814)) ([ebece6b](https://togithub.com/googleapis/java-shared-config/commit/ebece6b7df6208527450c12368fcc0c6ce07ac67)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/sdk-platform-java).

#2944) * deps: update dependency com.google.cloud:google-cloud-trace to v2.37.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

resourcemanager: bump dependency version
9bcae41
Fixes#2942.

pongad requested a review from garrettjonesgoogle February 23, 2018 04:33

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 23, 2018

pongad requested a review from vam-google February 23, 2018 04:34

garrettjonesgoogle reviewed Feb 23, 2018
View reviewed changes

vam-google reviewed Feb 24, 2018
View reviewed changes

pongad added 4 commits February 26, 2018 12:03

pr comment
ae8cb81

import
78a68d4

codacy
4654fda

java 7 doesn't have getOrDefault
5b3b3a7

vam-google reviewed Feb 28, 2018
View reviewed changes

pr comment
6258aac

pongad commented Feb 28, 2018
View reviewed changes

Comment thread...nager/src/main/java/com/google/cloud/resourcemanager/spi/v1beta1/HttpResourceManagerRpc.java
}

@Override
public boolean shouldRetry(Throwable prevThrowable, Operation prevOp) {
This comment was marked as spam.
Sign in to view

vam-google approved these changes Feb 28, 2018
View reviewed changes

pongad merged commit eed8800 into googleapis:masterFeb 28, 2018

pongad deleted the bump-resource branch February 28, 2018 23:08

chingor13 pushed a commit that referenced this pull request Mar 30, 2026
test(deps): update dependency org.junit:junit-bom to v5.12.0 (#2944)
4569a32

Uh oh!

Conversation

pongad commented Feb 23, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

pongad commented Feb 27, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

pongad commented Feb 28, 2018

Uh oh!

pongad commented Feb 28, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

vam-google left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants