Bigtable: 19 - Implement integration tests by igorbernstein2 · Pull Request #2997 · googleapis/google-cloud-java

igorbernstein2 · 2018-03-06T18:19:27Z

This is ready for review.

MVP of integration tests for Bigtable. All data rpcs are covered. The tests can be run against an emulator or a production instance of bigtable. For the time being, the emulator controller is implemented as a process wrapper around the cbtemulator binary that is managed by gcloud. The gcloud emulator command is bypassed because it executes the emulator as a child process, preventing java from killing it. The eventual goal is to publish the binaries wrapped in a jar and bypass gcloud altogether. The Emulator wrapper class is intentionally kept private in the tests directory to postpone committing to a public api.

I setup the CircleCi configs and created the target table in the test project. Also, I updated the ITs to run in parallel and updated the verify_single_it.sh scripts to take additional args

Sign in to view

+
+ private ManagedChannel createChannel(int port) {
+ return ManagedChannelBuilder.forAddress("localhost", port)
+ .usePlaintext(true)


pongad · 2018-03-18T23:51:45Z

The code LGTM. We should create a CircleCI task for this though. @igorbernstein2 Do you know what to do?

@garrettjonesgoogle I think making CI run against prod for integration is OK?

Sign in to view

+ void start() throws Exception {
+ int availablePort = getAvailablePort();
+
+ process = Runtime.getRuntime().exec(executable + " -port " + "" + availablePort);


igorbernstein2 · 2018-03-20T01:27:02Z

I updated this PR to include CircleCi configs. PTAL, if it looks ok, please merge

Sign in to view


 To use the `prod` environment:
-1. Create a table with a column family named `cf`.
+1. Setup the target table using `google-cloud-bigtable/scripts/setup-test-table.sh`


Sign in to view

@@ -0,0 +1,21 @@
+#!/usr/bin/env bash
+
+# Setup a table to use for integration tests.


Sign in to view

+ public void run() {
+ try {
+ String line;
+ while ((line = reader.readLine()) != null) LOGGER.log(level, line);


Sign in to view

+ throw new RuntimeException(
+ "Unknown env: "
+ + env
+ + ". Please set the system propert "


Sign in to view

+ testEnv = ProdEnv.fromSystemProperties();
+ break;
+ default:
+ throw new RuntimeException(


igorbernstein2 · 2018-03-20T18:55:08Z

Rebased & addressed all feedback. If it looks ok, please merge

igorbernstein2 · 2018-03-20T21:08:51Z

Thanks!

… to v2.29.1 (#2997) * chore(deps): update dependency com.google.cloud:google-cloud-bigtable to v2.29.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…3.42.0 (#2997)

* chore(main): release 2.51.0 * chore: generate libraries at Wed Apr 23 17:39:10 UTC 2025 * chore: cleanup changelog.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <cloud-java-bot@google.com> Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>

igorbernstein2 requested a review from pongad as a code owner March 6, 2018 18:19

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 6, 2018

igorbernstein2 changed the title ~~WIP: Bigtable: 20 - Implement integration tests~~WIP: Bigtable: 19 - Implement integration testsMar 6, 2018

igorbernstein2 force-pushed the 19-impl-integration-tests branch from 4f55a01 to efd2b05Compare March 8, 2018 03:59

igorbernstein2 changed the title ~~WIP: Bigtable: 19 - Implement integration tests~~Bigtable: 19 - Implement integration testsMar 8, 2018

igorbernstein2 commented Mar 15, 2018
View reviewed changes

garrettjonesgoogle reviewed Mar 19, 2018
View reviewed changes

garrettjonesgoogle reviewed Mar 20, 2018
View reviewed changes

igorbernstein2 added 15 commits March 20, 2018 14:39

First round of integration tests
dc087fb

wip
2a3687d

wip
1f212c9

tweaks
1dac3ad

english
c6d0e78

add shutdown hook for the emulator
9efb094

run integration tests in parallel
3859fee

use single property for target prod table
ab1af81

add script to setup the table
fadc70d

add bigtable integration tests to circleci
603fa39

update testing doc
c81396c

reformat
b8eb769

circleci fixes
acf2c69

update InstanceNames to the local copy
d75e0fa

address feedback & reformat
fc30c49

igorbernstein2 force-pushed the 19-impl-integration-tests branch from 2be85a7 to fc30c49Compare March 20, 2018 18:53

garrettjonesgoogle merged commit b7102bb into googleapis:masterMar 20, 2018

igorbernstein2 deleted the 19-impl-integration-tests branch March 20, 2018 21:08

chingor13 pushed a commit that referenced this pull request Mar 24, 2026
deps: update dependency com.google.cloud:google-cloud-monitoring to v…
c1e8b4b
…3.42.0 (#2997)

		@@ -0,0 +1,21 @@
		#!/usr/bin/env bash

		# Setup a table to use for integration tests.

Uh oh!

Conversation

igorbernstein2 commented Mar 6, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

pongad commented Mar 18, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

igorbernstein2 commented Mar 20, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

igorbernstein2 commented Mar 20, 2018

Uh oh!

igorbernstein2 commented Mar 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

igorbernstein2 commented Mar 6, 2018•
edited
Loading