Uh oh!
There was an error while loading. Please reload this page.
[WIP] make smoke test a test and an app - #3006
Closed
neozwu wants to merge 1 commit into
Closed
Conversation
| @@ -0,0 +1,21 @@ | |||
| /* | |||
| * Copyright 2016 Google LLC | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
neozwu
commented
Mar 26, 2018
ContributorAuthor
Close this PR since the function is implemented in separate PRs. |
chingor13 pushed a commit
that referenced
this pull request
Feb 20, 2026
Co-authored-by: Phong Chuong <147636638+PhongChuong@users.noreply.github.com>
suztomo pushed a commit
that referenced
this pull request
Mar 9, 2026
* feat: Add Routine DataGovernanceType This also: - fix an issue where RoutineInfo unit test was being skipped - fix an issue where ImportLibaries were not being exported in the toPb method * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: Add DataGovernanceType to clirr ignored difference --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
lqiu96 pushed a commit
that referenced
this pull request
Mar 20, 2026
Co-authored-by: Phong Chuong <147636638+PhongChuong@users.noreply.github.com>
chingor13 pushed a commit
that referenced
this pull request
Mar 24, 2026
lqiu96 added a commit
that referenced
this pull request
Aug 3, 2026
…ble writes and read channels When upgrading gRPC to v1.83.0 (and Gson to 2.14.0), Gson PR #3006 added strict duplicate key detection in MapTypeAdapterFactory.Adapter.read ('if (map.containsKey(key)) throw ...'). Because com.google.api.services.storage.model.StorageObject extends com.google.api.client.util.GenericData (which implements java.util.Map), raw Gson selects MapTypeAdapterFactory when serializing and deserializing StorageObject. However, GenericData.containsKey returns true for all @key annotated fields even before they are set, causing raw Gson.fromJson to throw JsonSyntaxException ('duplicate key') when deserializing StorageObject. This replaces raw Gson serialization and deserialization of StorageObject in ApiaryReadRequest and JsonResumableWrite with Google API Client's official JSON parser/serializer via JsonUtils (backed by JsonObjectParser / GsonFactory), resolving the duplicate key deserialization failure in SerializationTest.
lqiu96 added a commit
that referenced
this pull request
Aug 6, 2026
…ble writes and read channels (#13976) Found when upgradeing gRPC to v1.83.0 (as consequently Gson to v2.14.0) from #13967 Error: ``` 18:19:21:843 [ERROR] Errors: 18:19:21:843 [ERROR] SerializationTest>BaseSerializationTest.testRestorableObjects:67->BaseSerializationTest.serializeAndDeserialize:82 » JsonSyntax duplicate key: bucket ``` Seems to stem from Gson PR [#3006](google/gson#3006) which added strict duplicate key detection in MapTypeAdapterFactory.Adapter.read ('if (map.containsKey(key)) throw ...'). Possible Fix: Since com.google.api.services.storage.model.StorageObject extends com.google.api.client.util.GenericData (which implements java.util.Map), raw Gson selects MapTypeAdapterFactory when serializing and deserializing StorageObject. However, GenericData.containsKey returns true for all @key annotated fields even before they are set, causing raw Gson.fromJson to throw JsonSyntaxException ('duplicate key') when deserializing StorageObject. PR to replaces raw Gson serialization and deserialization of StorageObject in ApiaryReadRequest and JsonResumableWrite with Google API Client's official JSON parser/serializer via JsonUtils (backed by JsonObjectParser / GsonFactory), resolving the duplicate key deserialization failure in SerializationTest. Co-authored-by: Dhriti07 <56169283+Dhriti07@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesign autogenerated smoke test so that it has a "test entry point" and an "app entry point". Therefore, each smoke test can be run separately as a sample app (say, for debugging purpose). Or, all smoke tests can be run using mvn. ("mvn verify -P smoke-test"). For clients that require project-id, project-id can be detected through system property or environment variable. If app entry point is used, one can also pass project id through command line.