Skip to content

pubsub: make Publisher use GAPIC client - #3008

Merged
pongad merged 6 commits into
googleapis:masterfrom
pongad:pubsub-gapic
Mar 14, 2018
Merged

pubsub: make Publisher use GAPIC client#3008
pongad merged 6 commits into
googleapis:masterfrom
pongad:pubsub-gapic

Conversation

@pongad

@pongadpongad commented Mar 7, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 7, 2018
pongad
pongad commented Mar 7, 2018
View reviewed changes
Comment threadgoogle-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/PublisherImplTest.java
publisher.shutdown();
}

public void testPublishFailureRetries_exceededsRetryDuration() throws Exception {

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/TopicAdminSettings.java Outdated

/** Returns the object with the settings used for calls to publish. */
/* package-private */ BatchingCallSettings<PublishRequest, PublishResponse> publishSettings() {
/* package-private */ UnaryCallSettings<PublishRequest, PublishResponse> publishSettings() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle

garrettjonesgoogle commented Mar 7, 2018

Copy link
Copy Markdown
Contributor

@hzyi-google could you do the first pass?

yihanzhen
yihanzhen reviewed Mar 7, 2018
View reviewed changes
Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/stub/PublisherStubSettings.java Outdated
.setRetryableCodes(RETRYABLE_CODE_DEFINITIONS.get("non_idempotent"))
.setRetrySettings(RETRY_PARAM_DEFINITIONS.get("default"));

// builder

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/stub/PublisherStubSettings.java Outdated
BatchingCallSettings.newBuilder(PUBLISH_BATCHING_DESC)
.setBatchingSettings(BatchingSettings.newBuilder().build());
publishSettings = UnaryCallSettings.newUnaryCallSettingsBuilder();
// publishSettings =

This comment was marked as spam.

Sign in to view

@pongad

pongad commented Mar 8, 2018

Copy link
Copy Markdown
ContributorAuthor

@hzyi-google PTAL

@yihanzhen

yihanzhen commented Mar 8, 2018

Copy link
Copy Markdown
Contributor

LGTM

@pongad

pongad commented Mar 8, 2018

Copy link
Copy Markdown
ContributorAuthor

@garrettjonesgoogle \Do you also want to take a look?

garrettjonesgoogle
garrettjonesgoogle reviewed Mar 9, 2018
View reviewed changes
Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Outdated

private final Channel channel;
@Nullable private final CallCredentials callCredentials;
private final TopicAdminClient topicClient;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
closeables =
Collections.<AutoCloseable>singletonList(new ExecutorAsBackgroundResource(executor));
} else {
closeables = Collections.emptyList();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Outdated
try {
ApiException gaxException =
ApiExceptionFactory.createException(
t, GrpcStatusCode.of(Status.fromThrowable(t).getCode()), false);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad

pongad commented Mar 13, 2018

Copy link
Copy Markdown
ContributorAuthor

@garrettjonesgoogle PTAL

@pongad

pongad commented Mar 14, 2018

Copy link
Copy Markdown
ContributorAuthor

@garrettjonesgoogle Committed the test now

garrettjonesgoogle
garrettjonesgoogle approved these changes Mar 14, 2018
View reviewed changes

@garrettjonesgooglegarrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad
pongad merged commit 7f88505 into googleapis:masterMar 14, 2018
@pongad
pongad deleted the pubsub-gapic branch March 14, 2018 21:44
@pongad

pongad commented Mar 14, 2018

Copy link
Copy Markdown
ContributorAuthor

Thank you @garrettjonesgoogle . Sorry for the churn.

chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@renovate-bot@PhongChuong
deps: update googleapis/sdk-platform-java action to v2.59.1 (#3008)
1a5dd9c
Co-authored-by: Phong Chuong <147636638+PhongChuong@users.noreply.github.com>
suztomo pushed a commit that referenced this pull request Mar 9, 2026
@renovate-bot@gcf-owl-bot
build(deps): update dependency org.apache.maven.plugins:maven-project…
ffc32cf
…-info-reports-plugin to v3.5.0 (#3008)
* build(deps): update dependency org.apache.maven.plugins:maven-project-info-reports-plugin to v3.5.0
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request Mar 20, 2026
@renovate-bot@PhongChuong
deps: update googleapis/sdk-platform-java action to v2.59.1 (#3008)
93439df
Co-authored-by: Phong Chuong <147636638+PhongChuong@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@renovate-bot
deps: update actions/setup-java action to v4 (#3008)
4a0542a
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
fe6fc0f
…57.0 (#3008)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@yihanzhenyihanzhenyihanzhen left review comments
@garrettjonesgooglegarrettjonesgooglegarrettjonesgoogle approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pongad@garrettjonesgoogle@yihanzhen@googlebot