Uh oh!
There was an error while loading. Please reload this page.
storage: speed up IT - #3023
Merged
Merged
Conversation
We create fewer blobs since the basic case is already tested by other ITs. Fixes#3019, hopefully.
| while (Iterators.size(page.iterateAll().iterator()) != 2) { | ||
| String projectId = remoteStorageHelper.getOptions().getProjectId(); | ||
| for (; ; ) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
| Storage.BlobListOption.fields(), | ||
| Storage.BlobListOption.userProject(projectId)); | ||
| int size = Iterators.size(page.iterateAll().iterator()); | ||
| if (size == 1) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
pongad
commented
Mar 14, 2018
ContributorAuthor
@garrettjonesgoogle PTAL. I also slightly increased the time limit. Hopefully it flakes less. |
| // Otherwise, expect one blob, since we only put in one above. | ||
| if (!blobs.isEmpty()) { | ||
| assertThat(blobs).hasSize(1); | ||
| return; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chingor13 pushed a commit
that referenced
this pull request
Feb 20, 2026
suztomo pushed a commit
that referenced
this pull request
Mar 9, 2026
lqiu96 pushed a commit
that referenced
this pull request
Mar 20, 2026
chingor13 pushed a commit
that referenced
this pull request
Mar 24, 2026
* refactor: remove code related to prepareReadWriteTransactions. * chore: remove beginTransactionAsync method.
chingor13 pushed a commit
that referenced
this pull request
Mar 30, 2026
Expose publicly the project field which was previously internal only. This field represents the project number of the project the bucket belongs to. This field is still OUTPUT_ONLY, and as such does hot have a setter exposed for it. Fixes#3023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We create fewer blobs since the basic case is already
tested by other ITs.
Fixes#3019, hopefully.