Skip to content

PubSub: Update region tags to standard - #3281

Merged
alixhami merged 1 commit into
masterfrom
alixhami-patch-1
May 21, 2018
Merged

PubSub: Update region tags to standard#3281
alixhami merged 1 commit into
masterfrom
alixhami-patch-1

Conversation

@alixhami

Copy link
Copy Markdown
Contributor

No description provided.

@alixhamialixhami added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: pubsub Issues related to the Pub/Sub API. labels May 16, 2018
@alixhami
alixhami requested a review from jabubakeMay 16, 2018 21:09
@alixhami
alixhami requested a review from pongad as a code ownerMay 16, 2018 21:09
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2018

@pongadpongad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the place these get written to as well?

@alixhami

Copy link
Copy Markdown
ContributorAuthor

@pongad Yes, I am submitting PRs to all the languages to standardize the region tags, and the do not merge label will be on all the PRs until they are all ready and I can update the docs site at the same time.

@jabubakejabubake left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad

Copy link
Copy Markdown
Contributor

OK, LGTM but we're cutting a release now so let's hold off a little.

@alixhamialixhami removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 21, 2018
@alixhami
alixhami merged commit 70adcab into masterMay 21, 2018
@alixhami
alixhami deleted the alixhami-patch-1 branch May 21, 2018 22:05
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
🤖 I have created a release *beep* *boop*
---
<details><summary>2.47.1-SNAPSHOT</summary>
### Updating meta-information for bleeding-edge SNAPSHOT release.
</details>
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@alixhami@pongad@jabubake@googlebot