WIP: Instance admin client by spollapally · Pull Request #3497 · googleapis/google-cloud-java

spollapally · 2018-07-24T03:58:40Z

For model review. Needs documentation, unit tests and cleanup.

Sign in to view

+ }
+
+ if (listInstancesResponse.getFailedLocationsList().size() > 0) {
+ throw new FailedLocationException("Failed to list all locations", succeededLocations,


Sign in to view

+import com.google.protobuf.FieldMask;
+
+@BetaApi
+public final class InstanceAdminRequests {


Sign in to view

+ .getPermissionsList();
+ }
+
+ /** compose proto request helpers * */


Sign in to view

+ return appProfiles;
+ }
+
+ /** Can be removed after https://github.com/googleapis/gax-java/issues/552 is handled */


Sign in to view

+ return new CreateInstance(projectName, instance, cluster);
+ }
+
+ public static Instance convertToInstance(com.google.bigtable.admin.v2.Instance protoInstance) {


Sign in to view

+ protoUpdateProfile.setMultiClusterRoutingUseAny(
+ com.google.bigtable.admin.v2.AppProfile.MultiClusterRoutingUseAny.newBuilder().build());
+ protoUpdateProfile.clearSingleClusterRouting();
+ replacefields.add(MULTI_CLUSTER_FIELDMASK);


Sign in to view

+ public static class UpdateAppProfile {
+ private static final String DESCRIPTION_FIELDMASK = "description";
+ private static final String MULTI_CLUSTER_FIELDMASK = "multi_cluster_routing_use_any";
+ private static final String SINGLE_CLUSTER__FIELDMASK = "single_cluster_routing";


Sign in to view

+ RoutingPolicyCase name();
+ }
+
+ public static class RoutingPolicyNotSet implements RoutingPolicy {


Sign in to view

+ }
+
+ public RoutingPolicy getRoutingPolicy() {
+ if (RoutingPolicyCase.MULTI_CLUSTER_ROUTING_USE_ANY


Sign in to view

+ public static final class Policy {
+ private com.google.iam.v1.Policy.Builder protoPolicy = com.google.iam.v1.Policy.newBuilder();
+
+ public static Policy of(int version, Role role, List<String> members) {


igorbernstein2 · 2018-07-24T14:36:45Z

@kevinsi4508 can you take a look as well?

kevinsi4508 · 2018-07-24T16:22:16Z

I am going to take a look at high level.

kevinsi4508 · 2018-07-24T17:50:50Z

A few concerns:

Handling partial error.
It is not all consist on what need to passed to these API calls and the location of the request validation logic.
Handling responses in InstanceAdminRequests.

igorbernstein2 · 2018-08-30T21:59:04Z

@spollapally thanks for all of your work. I've broken up this PR into:
#3569 #3612 #3619
(plus an upcoming PR for iam)

So I'm going to close this now

spollapally · 2018-09-05T14:19:32Z

Thanks Igor.

…

-Sudharshan

On Thu, Aug 30, 2018 at 5:59 PM, Igor Bernstein ***@***.***> wrote: Closed #3497 <#3497>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3497 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AfisGOqjKhnAeNOjqsjmNi5-bSTOjf7wks5uWGAwgaJpZM4VcC4L> .

Use priority instead of job timeout to force non-fast query in executeSelect.

spollapally added 2 commits July 2, 2018 23:06

first-cut InstanceAdminClient Impl.
f103709

changes to DSL model objects
f5ec5c4

spollapally requested a review from pongad as a code owner July 24, 2018 03:58

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2018

igorbernstein2 changed the title ~~Instance admin client~~WIP: Instance admin clientJul 24, 2018

igorbernstein2 reviewed Jul 24, 2018
View reviewed changes

igorbernstein2 closed this Aug 30, 2018

suztomo pushed a commit that referenced this pull request Mar 9, 2026
test: fix flaky IT testExecuteSelectWithCredentials (#3497)
4930093
Use priority instead of job timeout to force non-fast query in executeSelect.

chingor13 pushed a commit that referenced this pull request Mar 30, 2026
test(deps): update dependency org.junit:junit-bom to v5.14.3 (#3497)
0816a0d

Uh oh!

Conversation

spollapally commented Jul 24, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

igorbernstein2 commented Jul 24, 2018

Uh oh!

kevinsi4508 commented Jul 24, 2018

Uh oh!

kevinsi4508 commented Jul 24, 2018

Uh oh!

igorbernstein2 commented Aug 30, 2018

Uh oh!

spollapally commented Sep 5, 2018 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants