Skip to content

BigQuery: Fixes When Table,Dataset and Job is not found - #4389

Merged
sduskis merged 4 commits into
googleapis:masterfrom
pmakani:api-bigquery-3930
Feb 25, 2019
Merged

BigQuery: Fixes When Table,Dataset and Job is not found #4389
sduskis merged 4 commits into
googleapis:masterfrom
pmakani:api-bigquery-3930

Conversation

@pmakani

Copy link
Copy Markdown

Fixes#3930 getTable(), getDataset() and getJob().

@pmakani
pmakani requested a review from a teamJanuary 18, 2019 11:35
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 18, 2019
@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2019

@sduskissduskis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmakani, can you please resolve the conflicts?

@sduskissduskis added the status: blocked Resolving the issue is dependent on other work. label Feb 7, 2019
@yoshi-automationyoshi-automation added 🚨 critical P0 critical issue. Requires immediate fix and removed 🚨 critical P0 critical issue. Requires immediate fix labels Feb 7, 2019
@codecov

codecovBot commented Feb 11, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4389 into master will decrease coverage by 4.1%.
The diff coverage is 33.33%.

Impacted file tree graph

@@ Coverage Diff @@## master #4389 +/- ##
============================================
- Coverage 49.19% 45.08% -4.11% - Complexity 21957 25313 +3356 
============================================
Files 2076 2078 +2 Lines 207407 247282 +39875 Branches 24108 31911 +7803 ============================================
+ Hits 102030 111491 +9461 - Misses 97205 126040 +28835 - Partials 8172 9751 +1579
Impacted FilesCoverage ΔComplexity Δ
...n/java/com/google/cloud/bigquery/BigQueryImpl.java83.46% <0%> (-0.81%)49 <0> (ø)
...ava/com/google/cloud/bigquery/BigQueryOptions.java88.88% <100%> (+1.01%)11 <2> (+2)⬆️
...loud/bigtable/data/v2/internal/RequestContext.java33.33% <0%> (-66.67%)2% <0%> (ø)
...gtable/admin/v2/BigtableInstanceAdminSettings.java82.14% <0%> (-17.86%)5% <0%> (-1%)
...com/google/cloud/bigquery/QueryParameterValue.java65.32% <0%> (-7.05%)43% <0%> (-3%)
...va/com/google/cloud/redis/v1/CloudRedisClient.java53.93% <0%> (-6.07%)23% <0%> (-12%)
...ble/data/v2/stub/EnhancedBigtableStubSettings.java93.19% <0%> (-5.37%)15% <0%> (-2%)
...gle/cloud/bigtable/data/v2/BigtableDataClient.java84.31% <0%> (-5.27%)32% <0%> (ø)
...a/com/google/cloud/bigquery/LegacySQLTypeName.java91.17% <0%> (-3.95%)4% <0%> (-3%)
...1/TargetHttpsProxiesSetSslCertificatesRequest.java19.48% <0%> (-3.93%)7% <0%> (+2%)
... and 794 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e0f2f...9096224. Read the comment docs.

@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@sduskissduskis removed the status: blocked Resolving the issue is dependent on other work. label Feb 20, 2019
@yoshi-automationyoshi-automation added the 🚨 critical P0 critical issue. Requires immediate fix label Feb 20, 2019
@pmakani

Copy link
Copy Markdown
Author

@sduskis PTAL.

@sduskis
sduskis merged commit 786ce15 into googleapis:masterFeb 25, 2019
@pmakani
pmakani deleted the api-bigquery-3930 branch February 25, 2019 15:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.🚨 criticalP0 critical issue. Requires immediate fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@pmakani@sduskis@googlebot@yoshi-automation@yoshi-kokoro