Skip to content

Set connect/read timeout when calling the metadata service - #4413

Merged
ajaaym merged 1 commit into
googleapis:masterfrom
dmichel1:master
Feb 8, 2019
Merged

Set connect/read timeout when calling the metadata service#4413
ajaaym merged 1 commit into
googleapis:masterfrom
dmichel1:master

Conversation

@dmichel1

@dmichel1dmichel1 commented Jan 26, 2019

Copy link
Copy Markdown

Otherwise callers of these methods can be waiting indefinitely.

Fixes#4398

@dmichel1
dmichel1 requested a review from a teamJanuary 26, 2019 18:11
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2019
@ajaaymajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2019
@dmichel1

dmichel1 commented Feb 5, 2019

Copy link
Copy Markdown
Author

@ajaaym can you take a look at this pls?

@sduskis

sduskis commented Feb 7, 2019

Copy link
Copy Markdown
Contributor

@dmichel1, can you please run mvn com.coveo:fmt-maven-plugin:format so that your code complies with our code formatting rule?

@sduskissduskis added the status: blocked Resolving the issue is dependent on other work. label Feb 7, 2019
@yoshi-automationyoshi-automation added the 🚨 critical P0 critical issue. Requires immediate fix label Feb 7, 2019
@dmichel1
Set connect/read timeout when calling the metadata service
3a5fd6a
Otherwise callers of these methods can be waiting indefinitely.
googleapis#4398
@dmichel1

dmichel1 commented Feb 8, 2019

Copy link
Copy Markdown
Author

@sduskis i rebased and pushed my code again - build should be passing.

@sduskissduskis added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed status: blocked Resolving the issue is dependent on other work. labels Feb 8, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
@dmichel1

dmichel1 commented Feb 8, 2019

Copy link
Copy Markdown
Author

Unrelated IT tests are failing for this PR now.

@sduskissduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
@sduskis

sduskis commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

I'll try to run the tests again, just to be sure.

@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
@dmichel1

dmichel1 commented Feb 8, 2019

Copy link
Copy Markdown
Author

@sduskis yaya they are passing now. thanks

@ajaaym
ajaaym merged commit 44db769 into googleapis:masterFeb 8, 2019
@JesseLovelaceJesseLovelace mentioned this pull request Feb 21, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ajaaymajaaymajaaym approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.🚨 criticalP0 critical issue. Requires immediate fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dmichel1@sduskis@ajaaym@googlebot@yoshi-automation@yoshi-kokoro