Skip to content

[bigtable] Addition of Row#fromProto - #4457

Closed
rahulKQL wants to merge 3 commits into
googleapis:masterfrom
rahulKQL:row_from_proto
Closed

[bigtable] Addition of Row#fromProto #4457
rahulKQL wants to merge 3 commits into
googleapis:masterfrom
rahulKQL:row_from_proto

Conversation

@rahulKQL

@rahulKQLrahulKQL commented Feb 6, 2019

Copy link
Copy Markdown
Contributor

Adding Row#fromProto to generate models.Row from protobuf Row.
Would need this feature for translation of model in BigtableDataClientWrapper, related in GBT-2061.

@rahulKQL
rahulKQL requested a review from a teamFebruary 6, 2019 15:48
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2019
@sduskissduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@sduskissduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 7, 2019
@igorbernstein2

igorbernstein2 commented Feb 7, 2019

Copy link
Copy Markdown
Contributor

I recently merged:
#4458

Any particular reason you'd want to have this on the model?

@sduskis

sduskis commented Feb 7, 2019

Copy link
Copy Markdown
Contributor

We can use #4458 instead.

@sduskissduskis closed this Feb 7, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sduskissduskissduskis left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rahulKQL@igorbernstein2@sduskis@googlebot@yoshi-kokoro