Skip to content

BigQuery: Fix support standard java date in QueryParameterValue classToType - #4489

Merged
sduskis merged 3 commits into
googleapis:masterfrom
pmakani:api-bigquery-3589
Feb 19, 2019
Merged

BigQuery: Fix support standard java date in QueryParameterValue classToType#4489
sduskis merged 3 commits into
googleapis:masterfrom
pmakani:api-bigquery-3589

Conversation

@pmakani

@pmakanipmakani commented Feb 13, 2019

Copy link
Copy Markdown

Fixes#3589 com.google.cloud.bigquery.QueryParameterValue classToType should support standard Java

@pmakani
pmakani requested a review from a teamFebruary 13, 2019 16:55
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2019
@codecov

codecovBot commented Feb 13, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4489 into master will increase coverage by <.01%.
The diff coverage is 63.63%.

Impacted file tree graph

@@ Coverage Diff @@## master #4489 +/- ##
============================================
+ Coverage 49.16% 49.16% +<.01% - Complexity 21913 21917 +4 
============================================
Files 2078 2078 Lines 207048 207059 +11 Branches 24084 24086 +2 ============================================
+ Hits 101789 101799 +10 - Misses 97116 97117 +1 
Partials 8143 8143
Impacted FilesCoverage ΔComplexity Δ
...com/google/cloud/bigquery/QueryParameterValue.java67.4% <63.63%> (+2.08%)47 <1> (+4)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4ce6c...8383bdf. Read the comment docs.

sduskis
sduskis suggested changes Feb 13, 2019
View reviewed changes
Comment thread...ients/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/QueryParameterValue.java Outdated
DateTimeFormatter.ofPattern("HH:mm:ss.SSSSSS");
private static final DateTimeFormatter datetimeFormatter =
DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss.SSSSSS");
private static final DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd");

@sduskissduskisFeb 13, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use DateTimeFormatter instead of the java standard format.

@pmakanipmakaniFeb 14, 2019•
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DateTimeFormatter is only available after java 8.

@sduskissduskisFeb 14, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see line 72.

@pmakanipmakaniFeb 14, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to remove formatter and replaced with utility method from google cloud date. Sorry I misread your comment earlier and though of jdk8s datetimeformatter.

@sduskissduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2019
@sduskis
sduskis merged commit 3bfe25e into googleapis:masterFeb 19, 2019
@JesseLovelaceJesseLovelace mentioned this pull request Feb 21, 2019
Merged
@pmakani
pmakani deleted the api-bigquery-3589 branch February 25, 2019 12:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sduskissduskissduskis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pmakani@sduskis@googlebot@yoshi-kokoro