Skip to content

Removing deprecated ServiceAccount creation in StorageImplTest. - #4490

Merged
sduskis merged 1 commit into
googleapis:masterfrom
sduskis:deprecated_sa
Feb 20, 2019
Merged

Removing deprecated ServiceAccount creation in StorageImplTest.#4490
sduskis merged 1 commit into
googleapis:masterfrom
sduskis:deprecated_sa

Conversation

@sduskis

Copy link
Copy Markdown
Contributor

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

@sduskis
sduskis requested a review from a teamFebruary 13, 2019 18:13
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2019
@codecov

codecovBot commented Feb 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4490 into master will decrease coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #4490 +/- ##
============================================
- Coverage 49.16% 48.52% -0.64% + Complexity 21915 20739 -1176 
============================================
Files 2078 2078 Lines 207082 203004 -4078 Branches 24084 23291 -793 ============================================
- Hits 101804 98517 -3287 + Misses 97135 96437 -698 + Partials 8143 8050 -93
Impacted FilesCoverage ΔComplexity Δ
...in/java/com/google/cloud/storage/StorageBatch.java88% <0%> (-4%)13% <0%> (ø)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java48.57% <0%> (-2.78%)10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java48.57% <0%> (-2.78%)10% <0%> (-2%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java55.88% <0%> (-2.46%)9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java55.88% <0%> (-2.46%)9% <0%> (-2%)
.../src/main/java/com/google/cloud/AsyncPageImpl.java64.28% <0%> (-2.39%)2% <0%> (ø)
...gle/cloud/storage/testing/RemoteStorageHelper.java55.37% <0%> (-2.36%)8% <0%> (ø)
... and 484 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ebac6...f96f5a6. Read the comment docs.

@igorbernstein2igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoshi-automationyoshi-automation added the 🚨 critical P0 critical issue. Requires immediate fix label Feb 20, 2019
@sduskis
sduskis merged commit e67981a into googleapis:masterFeb 20, 2019
@sduskis
sduskis deleted the deprecated_sa branch February 20, 2019 19:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.🚨 criticalP0 critical issue. Requires immediate fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@sduskis@igorbernstein2@JesseLovelace@googlebot@yoshi-automation