Skip to content

BigQuery: Fix timestamp parsing regression - #4510

Merged
sduskis merged 2 commits into
googleapis:masterfrom
pmakani:api-bigquery-bug-4500
Feb 20, 2019
Merged

BigQuery: Fix timestamp parsing regression#4510
sduskis merged 2 commits into
googleapis:masterfrom
pmakani:api-bigquery-bug-4500

Conversation

@pmakani

Copy link
Copy Markdown

Fixes#4500

@pmakani
pmakani requested review from a team and sduskisFebruary 15, 2019 21:23
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2019
@ajaaymajaaym changed the title Fixes BigQuery timestamp parsing.BigQuery: Fix timestamp parsing regressionFeb 15, 2019
@codecov

codecovBot commented Feb 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4510 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #4510 +/- ##
============================================
- Coverage 49.16% 49.14% -0.02% + Complexity 21929 21927 -2 
============================================
Files 2077 2078 +1 Lines 207074 207184 +110 Branches 24097 24106 +9 ============================================
+ Hits 101801 101815 +14 - Misses 97100 97196 +96 
Partials 8173 8173
Impacted FilesCoverage ΔComplexity Δ
...com/google/cloud/bigquery/QueryParameterValue.java68.84% <100%> (+3.51%)43 <1> (ø)⬇️
...loud/bigtable/data/v2/internal/RequestContext.java33.33% <0%> (-66.67%)2% <0%> (ø)
.../bigtable/admin/v2/BigtableTableAdminSettings.java78.37% <0%> (-21.63%)6% <0%> (ø)
...gtable/admin/v2/BigtableInstanceAdminSettings.java82.14% <0%> (-17.86%)5% <0%> (ø)
...ble/data/v2/stub/EnhancedBigtableStubSettings.java93.19% <0%> (-5.37%)15% <0%> (-2%)
...gle/cloud/bigtable/data/v2/BigtableDataClient.java84.31% <0%> (-5.27%)32% <0%> (ø)
...e/cloud/bigtable/data/v2/BigtableDataSettings.java31.7% <0%> (-3.43%)3% <0%> (ø)
...le/cloud/bigtable/data/v2/models/InstanceName.java0% <0%> (ø)0% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344fdac...2387727. Read the comment docs.

@AutoValue
public abstract class QueryParameterValue implements Serializable {

private static final DateTimeFormatter timestampValidator =

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace timestampFormatter with your configuration for timestampValidator?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't be done with single formatter.

@pmakani
pmakaniforce-pushed the api-bigquery-bug-4500 branch from 7700632 to 2387727CompareFebruary 19, 2019 17:23
@sduskissduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@sduskissduskis added the api: bigquery Issues related to the BigQuery API. label Feb 20, 2019
@sduskis
sduskis merged commit 7a6aa23 into googleapis:masterFeb 20, 2019
@pmakani
pmakani deleted the api-bigquery-bug-4500 branch February 25, 2019 12:36
@pmakani
pmakani restored the api-bigquery-bug-4500 branch February 28, 2019 17:11
@pmakani
pmakani deleted the api-bigquery-bug-4500 branch March 1, 2019 17:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pmakani@sduskis@googlebot@yoshi-kokoro