Skip to content

Datastore: Fix more_results value to query results - #4516

Merged
sduskis merged 4 commits into
googleapis:masterfrom
pmakani:api-datastore-4504
Feb 21, 2019
Merged

Datastore: Fix more_results value to query results#4516
sduskis merged 4 commits into
googleapis:masterfrom
pmakani:api-datastore-4504

Conversation

@pmakani

@pmakanipmakani commented Feb 19, 2019

Copy link
Copy Markdown

Fixes#4504

@pmakani
pmakani requested a review from a teamFebruary 19, 2019 18:18
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2019
@sduskissduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2019
@codecov

codecovBot commented Feb 20, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@e67981a). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@ Coverage Diff @@## master #4516 +/- ##
=========================================
Coverage ? 48.84% Complexity ? 21947 =========================================
Files ? 2077 Lines ? 207098 Branches ? 23429 =========================================
Hits ? 101153 Misses ? 97098 Partials ? 8847
Impacted FilesCoverage ΔComplexity Δ
...a/com/google/cloud/datastore/QueryResultsImpl.java88.23% <66.66%> (ø)17 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e67981a...ff2f1ef. Read the comment docs.

sduskis
sduskis reviewed Feb 20, 2019
View reviewed changes

@sduskissduskis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test for the getter.

@sduskissduskis added the api: datastore Issues related to the Datastore API. label Feb 20, 2019
@pmakani

pmakani commented Feb 21, 2019

Copy link
Copy Markdown
Author

Done.

@sduskis
sduskis merged commit a1679e4 into googleapis:masterFeb 21, 2019
@mtso

mtso commented Feb 21, 2019

Copy link
Copy Markdown

Thank you!

@JesseLovelaceJesseLovelace mentioned this pull request Feb 21, 2019
Merged
@pmakani
pmakani deleted the api-datastore-4504 branch February 25, 2019 12:31
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
Praful Makani@sduskis
Datastore: Fixmore_resultsvalue to query results (#4516)
b5dcd39
* add moreResults
* added getter
* updated code
* modified code and added test case
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sduskissduskissduskis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pmakani@mtso@sduskis@googlebot@yoshi-kokoro