Skip to content

[cloud spanner] Add dependency for surefire-junit47 - #4526

Merged
sduskis merged 3 commits into
googleapis:masterfrom
qian-long:junit-fix-upstream
Feb 21, 2019
Merged

[cloud spanner] Add dependency for surefire-junit47#4526
sduskis merged 3 commits into
googleapis:masterfrom
qian-long:junit-fix-upstream

Conversation

@qian-long

Copy link
Copy Markdown

Fixes junit dependency issue when running tests in a VPC.

@qian-long
qian-long requested a review from a teamFebruary 21, 2019 00:59
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2019
@qian-long

qian-long commented Feb 21, 2019

Copy link
Copy Markdown
Author

@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 21, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 21, 2019
@codecov

codecovBot commented Feb 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4526 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #4526 +/- ##
============================================
- Coverage 49.15% 49.15% -0.01% 
Complexity 21934 21934 ============================================
Files 2077 2077 Lines 207174 207174 Branches 24099 24099 ============================================
- Hits 101841 101838 -3 - Misses 97160 97163 +3 
Partials 8173 8173
Impacted FilesCoverage ΔComplexity Δ
...gle/cloud/storage/testing/RemoteStorageHelper.java55.28% <0%> (-2.44%)8% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ab941...73a4036. Read the comment docs.

@sduskis

Copy link
Copy Markdown
Contributor

Is this something we should apply for all projects?

@qian-long

Copy link
Copy Markdown
Author

I think this was only missing for spanner. For example, bigtable has a clause for this: https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-bigtable/pom.xml#L134

@sduskis
sduskis merged commit 227f5b8 into googleapis:masterFeb 21, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@qian-long@sduskis@googlebot@pmakani@yoshi-kokoro