Skip to content

Spanner: Refactor SpannerImpl - Move SessionImpl to separate file - #4895

Merged
kolea2 merged 4 commits into
googleapis:masterfrom
olavloite:spanner-refactor-spannerimpl-sessionimpl
Apr 15, 2019
Merged

Spanner: Refactor SpannerImpl - Move SessionImpl to separate file#4895
kolea2 merged 4 commits into
googleapis:masterfrom
olavloite:spanner-refactor-spannerimpl-sessionimpl

Conversation

@olavloite

Copy link
Copy Markdown
Contributor

Move SessionImpl from SpannerImpl to a separate class file.

@olavloite
olavloite requested a review from a teamApril 3, 2019 11:18
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2019
@codecov

codecovBot commented Apr 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4895 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #4895 +/- ##
=========================================
Coverage 50.35% 50.35% Complexity 23639 23639 =========================================
Files 2231 2231 Lines 225723 225723 Branches 24935 24935 =========================================
Hits 113674 113674 Misses 103462 103462 Partials 8587 8587
Impacted FilesCoverage ΔComplexity Δ
...src/main/java/com/google/cloud/ServiceOptions.java41.48% <0%> (ø)27% <0%> (ø)⬇️
...om/google/cloud/logging/MonitoredResourceUtil.java50.92% <0%> (ø)8% <0%> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47884a3...bab1cca. Read the comment docs.

@olavloiteolavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
@olavloite
olavloiteforce-pushed the spanner-refactor-spannerimpl-sessionimpl branch from fa1c0ad to 03d284eCompareApril 6, 2019 09:25
@yoshi-automationyoshi-automation added the 🚨 critical P0 critical issue. Requires immediate fix label Apr 10, 2019
@sduskis
sduskis requested review from kolea2 and removed request for a teamApril 11, 2019 15:32
@olavloite
olavloiteforce-pushed the spanner-refactor-spannerimpl-sessionimpl branch from 03d284e to bab1ccaCompareApril 12, 2019 05:38
@kolea2
kolea2 merged commit be7ece5 into googleapis:masterApr 15, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.🚨 criticalP0 critical issue. Requires immediate fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@olavloite@sduskis@googlebot@yoshi-automation@yoshi-kokoro@kolea2