Skip to content

CSCC Snippets - #4917

Merged
sduskis merged 10 commits into
masterfrom
cscc_examples
Apr 15, 2019
Merged

CSCC Snippets#4917
sduskis merged 10 commits into
masterfrom
cscc_examples

Conversation

@emkornfield

Copy link
Copy Markdown

Add remaining snippets for CSCC

@emkornfield
emkornfield requested a review from a teamApril 5, 2019 21:38
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2019
@codecov

codecovBot commented Apr 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4917 into master will decrease coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #4917 +/- ##
============================================
- Coverage 50.35% 49.71% -0.64% + Complexity 23618 22300 -1318 
============================================
Files 2231 2233 +2 Lines 225686 221150 -4536 Branches 24929 24078 -851 ============================================
- Hits 113634 109945 -3689 + Misses 103463 102750 -713 + Partials 8589 8455 -134
Impacted FilesCoverage ΔComplexity Δ
...ava/com/google/cloud/storage/BlobWriteChannel.java71.66% <0%> (-19.51%)9% <0%> (+4%)
...in/java/com/google/cloud/storage/StorageBatch.java88% <0%> (-4%)13% <0%> (ø)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java48.57% <0%> (-2.78%)10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java48.57% <0%> (-2.78%)10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java63.41% <0%> (-2.5%)12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java55.88% <0%> (-2.46%)9% <0%> (-2%)
... and 547 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2167ed3...2813fee. Read the comment docs.

@emkornfield
emkornfield requested a review from sduskisApril 8, 2019 18:41
@sduskis

Copy link
Copy Markdown
Contributor

@emkornfield, you need to run mvn com.coveo:fmt-maven-plugin:format again.

@emkornfield

Copy link
Copy Markdown
Author

Sorry about that. done.

@yoshi-automationyoshi-automation added the 🚨 critical P0 critical issue. Requires immediate fix label Apr 12, 2019

@sduskissduskis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a small fix. Please address it before merging.

}
}
// [END list_asset_changes_status_changes]
// [END list_asset_changes_status_changes]\

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the trailing \

@sduskis
sduskis merged commit aace1e5 into masterApr 15, 2019
@sduskis
sduskis deleted the cscc_examples branch May 1, 2019 17:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.🚨 criticalP0 critical issue. Requires immediate fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@emkornfield@sduskis@googlebot@yoshi-automation