Skip to content

[Bigtable] CreateTableRequest equals and hashCode with unit test - #5079

Merged
sduskis merged 3 commits into
googleapis:masterfrom
rahulKQL:createTableunitTest
May 10, 2019
Merged

[Bigtable] CreateTableRequest equals and hashCode with unit test#5079
sduskis merged 3 commits into
googleapis:masterfrom
rahulKQL:createTableunitTest

Conversation

@rahulKQL

Copy link
Copy Markdown
Contributor

More information: #5066 (comment)

  • Fixed CreateTableRequest#equals & hashCode
  • Added unit test for equals, hashCode & toProto.

rahulKQL added 2 commits May 7, 2019 16:48
Fix `CreateTableRequest#equals` & `hashCode`
Added unit test for equals, hashCode & toProto.
@rahulKQL
rahulKQL requested a review from a teamMay 7, 2019 12:41
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2019
@rahulKQL

Copy link
Copy Markdown
ContributorAuthor

@igorbernstein2 Please have a look

@igorbernstein2igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label May 7, 2019
@rahulKQL

Copy link
Copy Markdown
ContributorAuthor

@igorbernstein2 This PR is ready for another round of review, PTAL.

@sduskissduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2019
@codecov

codecovBot commented May 10, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5079 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #5079 +/- ##
============================================
+ Coverage 50.38% 50.4% +0.02% - Complexity 23735 23785 +50 
============================================
Files 2248 2251 +3 Lines 226478 226785 +307 Branches 24954 24966 +12 ============================================
+ Hits 114113 114314 +201 - Misses 103772 103864 +92 - Partials 8593 8607 +14
Impacted FilesCoverage ΔComplexity Δ
...d/bigtable/admin/v2/models/CreateTableRequest.java85.18% <100%> (+10.99%)8 <2> (+2)⬆️
...n/java/com/google/cloud/bigquery/BigQueryImpl.java80.21% <0%> (-3.89%)58% <0%> (+5%)
...e/cloud/bigquery/testing/RemoteBigQueryHelper.java62.5% <0%> (-1.14%)6% <0%> (ø)
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java6.1% <0%> (-0.83%)2% <0%> (ø)
.../talent/v4beta1/stub/EventServiceStubSettings.java78.48% <0%> (-0.27%)10% <0%> (ø)
...alent/v4beta1/stub/ProfileServiceStubSettings.java75.32% <0%> (-0.16%)16% <0%> (ø)
...talent/v4beta1/stub/TenantServiceStubSettings.java80% <0%> (-0.16%)15% <0%> (ø)
...alent/v4beta1/stub/CompanyServiceStubSettings.java80% <0%> (-0.16%)15% <0%> (ø)
...t/v4beta1/stub/ApplicationServiceStubSettings.java80.15% <0%> (-0.16%)15% <0%> (ø)
...ud/talent/v4beta1/stub/JobServiceStubSettings.java72.48% <0%> (-0.15%)18% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae4a9d...97406fd. Read the comment docs.

@sduskis
sduskis merged commit cc54764 into googleapis:masterMay 10, 2019
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
…gleapis#5079)
* CreateTableRequest update with unit test
Fix `CreateTableRequest#equals` & `hashCode`
Added unit test for equals, hashCode & toProto.
* Fix test cases and applied formatting
* Address feedback for class imports
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@rahulKQL@igorbernstein2@sduskis@googlebot@yoshi-kokoro