Skip to content

[Bigtable] Added StreamController cancel in readRowsAsync docs - #5125

Merged
igorbernstein2 merged 2 commits into
googleapis:masterfrom
rahulKQL:streamcancel
May 10, 2019
Merged

[Bigtable] Added StreamController cancel in readRowsAsync docs#5125
igorbernstein2 merged 2 commits into
googleapis:masterfrom
rahulKQL:streamcancel

Conversation

@rahulKQL

@rahulKQLrahulKQL commented May 8, 2019

Copy link
Copy Markdown
Contributor

Fixes#4229

This change contains a simple example of how to cancel a stream received from BigtableDataClient#readRowsAsync.

@rahulKQL
rahulKQL requested a review from a teamMay 8, 2019 18:28
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2019
@rahulKQL

rahulKQL commented May 8, 2019

Copy link
Copy Markdown
ContributorAuthor

@igorbernstein2 PTAL, Also please let me know if this sample code needs to be more concrete/realistic.

@rahulKQLrahulKQL changed the title [WIP] [Bigtable] Added StreamController cancel in readRowsAsync docs[Bigtable] Added StreamController cancel in readRowsAsync docsMay 8, 2019
@sduskissduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2019
@rahulKQL

rahulKQL commented May 10, 2019

Copy link
Copy Markdown
ContributorAuthor

@igorbernstein2
I have addressed both feedback comments. PTAL and merge if it looks good to you.

@igorbernstein2
igorbernstein2 merged commit 2313bb5 into googleapis:masterMay 10, 2019
@chingor13chingor13 mentioned this pull request May 15, 2019
Merged
@rahulKQL
rahulKQL deleted the streamcancel branch May 21, 2019 12:53
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@rahulKQL@igorbernstein2
[Bigtable] Added StreamController cancel in readRowsAsync docs (googl…
37c089e
…eapis#5125)
* Added StremController cancel in readRowsAsync docs
* Updating the Sample code with better approach
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2igorbernstein2igorbernstein2 approved these changes

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bigtable: add docs demonstrating stream cancellation

5 participants

@rahulKQL@igorbernstein2@sduskis@googlebot@yoshi-kokoro