Skip to content

Migrate from isSameAs to isSameInstanceAs (and isNotSameAs to isNotSameInstanceAs). - #5172

Merged
sduskis merged 1 commit into
googleapis:masterfrom
cpovirk:sameas
May 13, 2019
Merged

Migrate from isSameAs to isSameInstanceAs (and isNotSameAs to isNotSameInstanceAs).#5172
sduskis merged 1 commit into
googleapis:masterfrom
cpovirk:sameas

Conversation

@cpovirk

Copy link
Copy Markdown

The new methods behave identically to the old, which are being removed.

The new methods were added to Truth in version 0.44.

…meInstanceAs).
The new methods behave identically to the old, which are being removed.
The new methods were added to Truth in version 0.44.
@cpovirk
cpovirk requested a review from a teamMay 10, 2019 20:24
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2019
@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@cpovirk

Copy link
Copy Markdown
Author

OS X failures are probably unrelated.

@kolea2kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@sduskis
sduskis merged commit 6b78c52 into googleapis:masterMay 13, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@cpovirk@kolea2@sduskis@googlebot@pmakani@yoshi-kokoro