Skip to content

Regenerate bigquerystorage client - #5198

Merged
pmakani merged 2 commits into
masterfrom
autosynth-bigquerystorage
May 25, 2019
Merged

Regenerate bigquerystorage client#5198
pmakani merged 2 commits into
masterfrom
autosynth-bigquerystorage

Conversation

@yoshi-automation

Copy link
Copy Markdown
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/google-cloud-clients/google-cloud-bigquerystorage/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:d3df563538225ac6caac45d8ad86499500211d1bcb2536955a6dbda15e1b368e
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/bigquery/storage/artman_bigquerystorage_v1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running java formatter on 20 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 4 files
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation
yoshi-automation requested a review from a teamMay 18, 2019 07:35
@yoshi-automation
yoshi-automationforce-pushed the autosynth-bigquerystorage branch from d851d5c to 48e98daCompareMay 18, 2019 07:35
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2019
@tswast
tswast requested a review from shollymanMay 21, 2019 16:12
@sduskis

Copy link
Copy Markdown
Contributor

The unit tests are failing:

[ERROR] ReadRowsRetryTest.multipleRetryTestWithNonZeroInitialOffset » DeadlineExceeded
[ERROR] ReadRowsRetryTest.multipleRetryTestWithZeroInitialOffset » DeadlineExceeded io...

@sduskis

Copy link
Copy Markdown
Contributor

@shollyman, we no longer retry on DEADLINE_EXCEEDED by default. Should we remove the tests that expect a retry?

@shollyman

Copy link
Copy Markdown
Contributor

Put together #5219 to address tests expecting retries for DEADLINE_EXCEEDED. Once that's in this can land.

@sduskissduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2019
@sduskis

Copy link
Copy Markdown
Contributor

@shollyman Thanks! I'm rerunning the tests now.

@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2019
@codecov

codecovBot commented May 24, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@9d0badf). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #5198 +/- ##
=========================================
Coverage ? 50.45% Complexity ? 23855 =========================================
Files ? 2257 Lines ? 227301 Branches ? 24976 =========================================
Hits ? 114694 Misses ? 103989 Partials ? 8618
Impacted FilesCoverage ΔComplexity Δ
...rage/v1beta1/stub/BigQueryStorageStubSettings.java84.5% <100%> (ø)14 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0badf...20e7681. Read the comment docs.

@pmakani
pmakani merged commit 740b5e9 into masterMay 25, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@yoshi-automation@sduskis@shollyman@googlebot@pmakani@yoshi-kokoro