Uh oh!
There was an error while loading. Please reload this page.
Update NIO to understand new directory stand-ins - #5204
Merged
chingor13 merged 4 commits intoMay 28, 2019
Merged
Conversation
The web interface has a "create folder" button, and that creates a file ending in '/' that is used to pretend the folder exists. The web interface maintains the illusion but of course this is still only a file, so all clients (this one included) has to play along and pretend the directory exists (or users get confused). Those fake folders used to be 0-byte, but no longer. This pull request updates our code so it just looks at the trailing slash, ignoring the size of the file. It also adds a test, and in order to write the test we had to add the ability to create files whose name ends in '/', for test purpose only.
pmakani
reviewed
May 21, 2019
Uh oh!
There was an error while loading. Please reload this page.
pmakani
reviewed
May 21, 2019
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #5204 +/- ##
============================================
+ Coverage 50.42% 50.42% +<.01% - Complexity 23796 23816 +20
============================================
Files 2251 2252 +1 Lines 226836 226841 +5 Branches 24966 24961 -5 ============================================
+ Hits 114371 114380 +9 + Misses 103858 103855 -3 + Partials 8607 8606 -1
Continue to review full report at Codecov.
|
sduskis
commented
May 22, 2019
Contributor
Please run |
jean-philippe-martin
commented
May 22, 2019
Author
@sduskis done. |
chingor13
requested changes
May 22, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jean-philippe-martin
commented
May 28, 2019
Author
I hope everyone had a good weekend! @chingor13 the code should be ready, let me know in case there's still a ball in my camp! |
chingor13
approved these changes
May 28, 2019
jean-philippe-martin
commented
May 28, 2019
Author
Thank you very much! |
jean-philippe-martin
deleted the
jp_update_to_latest_fake_folder_convention
branch
May 28, 2019 18:03
suztomo pushed a commit
that referenced
this pull request
Mar 30, 2026
* Update NIO to understand directory stand-ins The web interface has a "create folder" button, and that creates a file ending in '/' that is used to pretend the folder exists. The web interface maintains the illusion but of course this is still only a file, so all clients (this one included) has to play along and pretend the directory exists (or users get confused). Those fake folders used to be 0-byte, but no longer. This pull request updates our code so it just looks at the trailing slash, ignoring the size of the file. It also adds a test, and in order to write the test we had to add the ability to create files whose name ends in '/', for test purpose only. * formatting changes * formatting * Update (C) year
lqiu96 pushed a commit
that referenced
this pull request
Apr 1, 2026
* Update NIO to understand directory stand-ins The web interface has a "create folder" button, and that creates a file ending in '/' that is used to pretend the folder exists. The web interface maintains the illusion but of course this is still only a file, so all clients (this one included) has to play along and pretend the directory exists (or users get confused). Those fake folders used to be 0-byte, but no longer. This pull request updates our code so it just looks at the trailing slash, ignoring the size of the file. It also adds a test, and in order to write the test we had to add the ability to create files whose name ends in '/', for test purpose only. * formatting changes * formatting * Update (C) year
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web interface has a "create folder" button, and that creates
a file ending in '/' that is used to pretend the folder exists.
The web interface maintains the illusion but of course this is still only a file,
so all clients (this one included) has to play along and pretend the directory
exists (or users get confused).
Those fake folders used to be 0-byte, but no longer. This pull request
updates our code so it just looks at the trailing slash, ignoring the size
of the file.
It also adds a test, and in order to write the test we had to add the ability
to create files whose name ends in '/', for test purpose only.
Fixes#5203