Skip to content

Bigtable: clean up redundant code - #5286

Merged
chingor13 merged 2 commits into
googleapis:masterfrom
liubonan:master
Jul 30, 2019
Merged

Bigtable: clean up redundant code#5286
chingor13 merged 2 commits into
googleapis:masterfrom
liubonan:master

Conversation

@liubonan

Copy link
Copy Markdown

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

@liubonan
liubonan requested a review from a teamJune 3, 2019 22:12
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 3, 2019
@sduskis

Copy link
Copy Markdown
Contributor

@liubonan, can you please run mvn com.coveo:fmt-maven-plugin:format to fix the code format?

@igorbernstein2igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please run the formatter

@yoshi-automationyoshi-automation added the 🚨 critical P0 critical issue. Requires immediate fix label Jun 10, 2019
@yoshi-automationyoshi-automation removed the 🚨 critical P0 critical issue. Requires immediate fix label Jul 3, 2019
@codecov

codecovBot commented Jul 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5286 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #5286 +/- ##
============================================
+ Coverage 50.47% 50.48% +<.01% 
Complexity 23875 23875 ============================================
Files 2258 2258 Lines 227482 227482 Branches 24978 24978 ============================================
+ Hits 114828 114834 +6 + Misses 104035 104029 -6 
Partials 8619 8619
Impacted FilesCoverage ΔComplexity Δ
.../cloud/datastore/testing/LocalDatastoreHelper.java85.07% <0%> (+4.47%)17% <0%> (ø)⬇️
.../java/com/google/cloud/testing/CommandWrapper.java96.96% <0%> (+9.09%)13% <0%> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d04900a...296e428. Read the comment docs.

@chingor13chingor13 changed the title Redundant Code Clean Up.Bigtable: clean up redundant codeJul 30, 2019
@chingor13
chingor13 merged commit 9cfe553 into googleapis:masterJul 30, 2019
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
* Redundant Code Clean Up.
* Fix lint
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@liubonan@sduskis@chingor13@igorbernstein2@googlebot@yoshi-automation