Skip to content

Storage: add service api to read storage object in to output stream using direct download - #5525

Merged
ajaaym merged 3 commits into
googleapis:masterfrom
ajaaym:towards_#3929_2
Jul 9, 2019
Merged

Storage: add service api to read storage object in to output stream using direct download#5525
ajaaym merged 3 commits into
googleapis:masterfrom
ajaaym:towards_#3929_2

Conversation

@ajaaym

Copy link
Copy Markdown
Contributor

towards #3929

Note: This pr just adds the service api. There would be follow up pr to this one which would add public api to download blob as a file or in to output stream using this service api.

@ajaaym
ajaaym requested a review from a teamJune 20, 2019 17:32
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2019
@ajaaymajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@ajaaymajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2019
@ajaaymajaaym added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2019
@codecov

codecovBot commented Jun 24, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5525 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@## master #5525 +/- ##
============================================
- Coverage 50.86% 50.85% -0.01% + Complexity 24193 24192 -1 
============================================
Files 2270 2270 Lines 230115 230151 +36 Branches 25009 25015 +6 ============================================
- Hits 117043 117041 -2 - Misses 104435 104472 +37 - Partials 8637 8638 +1
Impacted FilesCoverage ΔComplexity Δ
...va/com/google/cloud/storage/spi/v1/StorageRpc.java62.85% <ø> (ø)0 <0> (ø)⬇️
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java1.81% <0%> (-0.04%)1 <0> (ø)
...ud/storage/contrib/nio/testing/FakeStorageRpc.java59.21% <0%> (-5.39%)42 <0> (ø)
...able/gaxx/reframing/ReframingResponseObserver.java88.99% <0%> (-1.84%)29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d305770...d061eb0. Read the comment docs.

@ajaaym

Copy link
Copy Markdown
ContributorAuthor

@frankyn@JesseLovelace can you please review?

@yoshi-automationyoshi-automation added 🚨 critical P0 critical issue. Requires immediate fix and removed 🚨 critical P0 critical issue. Requires immediate fix labels Jun 27, 2019
@ajaaym
ajaaym merged commit d67dc01 into googleapis:masterJul 9, 2019
@astroyang

Copy link
Copy Markdown

Is there an estimated time for the next step of adding a public api to download blob using this? @ajaaym

@ajaaym

Copy link
Copy Markdown
ContributorAuthor

@astroyang#5791 is merged yesterday.

suztomo pushed a commit that referenced this pull request Mar 30, 2026
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@ajaaym@astroyang@JesseLovelace@frankyn@googlebot@yoshi-automation@yoshi-kokoro