Uh oh!
There was an error while loading. Please reload this page.
bigquery: reduce test flakiness in testCancelJob integration test. - #5592
Merged
Conversation
BigQuery's cancellation mechanism is best-effort notification to the job server running cancellation. Depending on a timing factors, the cancellation can be ignored, arrive after job completion, or arrive in time to trigger state transition (which will yield an error). This change removes the expectation that cancelling a job won't yield an error, which is incorrect for the last case.
Codecov Report
@@ Coverage Diff @@## master #5592 +/- ##
============================================
+ Coverage 46.71% 46.71% +<.01%
Complexity 24624 24624 ============================================
Files 2351 2351 Lines 256121 256121 Branches 29323 29323 ============================================
+ Hits 119639 119645 +6 + Misses 127563 127557 -6
Partials 8919 8919
Continue to review full report at Codecov.
|
tswast
approved these changes
Jun 28, 2019
This was referenced Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigQuery's cancellation mechanism is best-effort notification to
the job server running cancellation. Depending on a timing factors,
the cancellation can be ignored, arrive after job completion, or
arrive in time to trigger premature state transition (which will yield an error).
This change removes the expectation that cancelling a job won't yield an error,
which is incorrect for the last case (which is triggered rarely).