Skip to content

Add VPC-SC positive and negative integration tests in Web Security Scanner - #5594

Merged
chingor13 merged 7 commits into
googleapis:masterfrom
ashishin:add-vpcsc-beta-tests
Jul 10, 2019
Merged

Add VPC-SC positive and negative integration tests in Web Security Scanner#5594
chingor13 merged 7 commits into
googleapis:masterfrom
ashishin:add-vpcsc-beta-tests

Conversation

@ashishin

Copy link
Copy Markdown
Contributor

This add VPC-SC positive and negative integration tests in Web Security Scanner.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 28, 2019
@ashishin
ashishin marked this pull request as ready for review June 28, 2019 23:03
@ashishin
ashishin requested a review from a teamJune 28, 2019 23:03
@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@yoshi-kokoroyoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 1, 2019

@chingor13chingor13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please run mvn com.coveo:fmt-maven-plugin:format to appease the code linter.

@chingor13chingor13 added the needs work This is a pull request that needs a little love. label Jul 8, 2019
@codecov

codecovBot commented Jul 9, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5594 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #5594 +/- ##
============================================
+ Coverage 46.72% 46.79% +0.06% - Complexity 24647 24993 +346 
============================================
Files 2351 2382 +31 Lines 256149 259161 +3012 Branches 29327 28578 -749 ============================================
+ Hits 119688 121270 +1582 - Misses 127539 128186 +647 - Partials 8922 9705 +783
Impacted FilesCoverage ΔComplexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java48.95% <0%> (-6.46%)139% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java51.14% <0%> (-5.94%)55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java49.63% <0%> (-5.84%)35% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java50.41% <0%> (-5.79%)31% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java48.92% <0%> (-5.76%)35% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java50% <0%> (-5.74%)31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java49.04% <0%> (-5.74%)43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java48.57% <0%> (-5.72%)35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java48.1% <0%> (-5.7%)39% <0%> (ø)
...d/compute/v1/RegionInstanceGroupManagerClient.java48.81% <0%> (-5.69%)51% <0%> (ø)
... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71124ba...597c390. Read the comment docs.

@chingor13chingor13 self-assigned this Jul 9, 2019
@chingor13chingor13 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed needs work This is a pull request that needs a little love. labels Jul 9, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2019
…ive and VPCServiceControlPositive respectively. Renamed methods in VPCServiceControlPositiveTest. Changed caught exception in VPCServiceControlNegativeTest.
@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@chingor13
chingor13 merged commit ab6a85b into googleapis:masterJul 10, 2019
@JesseLovelaceJesseLovelace mentioned this pull request Jul 17, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ashishin@chingor13@googlebot@yoshi-kokoro