Skip to content

Core: Cleanup unused dependencies - #5617

Merged
chingor13 merged 3 commits into
googleapis:masterfrom
athakor:cleanup-dependency-core-4383
Jul 30, 2019
Merged

Core: Cleanup unused dependencies#5617
chingor13 merged 3 commits into
googleapis:masterfrom
athakor:cleanup-dependency-core-4383

Conversation

@athakor

@athakorathakor commented Jul 1, 2019

Copy link
Copy Markdown
Contributor

towards #4383

@athakor
athakor requested a review from a teamJuly 1, 2019 12:22
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2019
@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@sduskissduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@codecov

codecovBot commented Jul 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5617 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #5617 +/- ##
============================================
- Coverage 46.71% 46.71% -0.01% - Complexity 24625 24639 +14 
============================================
Files 2351 2351 Lines 256121 256121 Branches 29323 29318 -5 ============================================
- Hits 119647 119645 -2 - Misses 127556 127557 +1 - Partials 8918 8919 +1
Impacted FilesCoverage ΔComplexity Δ
...able/gaxx/reframing/ReframingResponseObserver.java88.99% <0%> (-1.84%)29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b16af...7933532. Read the comment docs.

@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019
@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2019
@chingor13chingor13 self-assigned this Jul 30, 2019
@chingor13chingor13 changed the title Google Cloud Core : Cleanup dependencyCore: Cleanup unused dependenciesJul 30, 2019
@chingor13
chingor13 merged commit 32100ee into googleapis:masterJul 30, 2019
@kolea2kolea2 mentioned this pull request Jul 31, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13chingor13chingor13 approved these changes

Assignees

@chingor13chingor13

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@athakor@chingor13@sduskis@googlebot@pmakani@yoshi-kokoro