Skip to content

[Bigtable] Fixes Query#toProto state change effect - #5621

Merged
sduskis merged 1 commit into
googleapis:masterfrom
rahulKQL:fixforquery
Jul 1, 2019
Merged

[Bigtable] Fixes Query#toProto state change effect#5621
sduskis merged 1 commit into
googleapis:masterfrom
rahulKQL:fixforquery

Conversation

@rahulKQL

@rahulKQLrahulKQL commented Jul 1, 2019

Copy link
Copy Markdown
Contributor

Fixes#5550

This change address the hashcode change problem of Query after calling Query#toProto.

@rahulKQL
Fixes Query#toProto state change effect
0f4aefe
This change address the hashcode change problem of Query after calling toProto.
@rahulKQL
rahulKQL requested a review from a teamJuly 1, 2019 13:53
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2019
@rahulKQL

rahulKQL commented Jul 1, 2019

Copy link
Copy Markdown
ContributorAuthor

@igorbernstein2, @sduskis Please have a look.

igorbernstein2
igorbernstein2 approved these changes Jul 1, 2019
View reviewed changes

@igorbernstein2igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@igorbernstein2igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@igorbernstein2igorbernstein2 added api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 1, 2019
@sduskis
sduskis merged commit 9062789 into googleapis:masterJul 1, 2019
This was referenced Jul 2, 2019
Closed
Merged
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@rahulKQL@sduskis
Fixes Query#toProto state change effect (googleapis#5621)
bf069e3
This change address the hashcode change problem of Query after calling toProto.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2igorbernstein2igorbernstein2 approved these changes

Assignees

No one assigned

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to use Bigtable Query object as cache key

5 participants

@rahulKQL@igorbernstein2@sduskis@googlebot@yoshi-kokoro