Skip to content

Add Tasks smoke test - #5628

Merged
chingor13 merged 7 commits into
googleapis:masterfrom
chingor13:tasks-smoke-test
Jul 3, 2019
Merged

Add Tasks smoke test#5628
chingor13 merged 7 commits into
googleapis:masterfrom
chingor13:tasks-smoke-test

Conversation

@chingor13

Copy link
Copy Markdown
Contributor

This test is adapted from java-docs-samples.

@chingor13
chingor13 requested a review from a teamJuly 1, 2019 20:10
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2019
@codecov-io

codecov-io commented Jul 1, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5628 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #5628 +/- ##
=========================================
Coverage 46.71% 46.71% Complexity 24629 24629 =========================================
Files 2351 2351 Lines 256127 256127 Branches 29325 29325 =========================================
Hits 119648 119648 Misses 127559 127559 Partials 8920 8920

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b15d1...e6fdc64. Read the comment docs.


@Test
public void run() {
main(null);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor - want to inline this?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the existing format for the generated SmokeTests (example)

@chingor13
chingor13 merged commit 13928f8 into googleapis:masterJul 3, 2019
@chingor13
chingor13 deleted the tasks-smoke-test branch July 3, 2019 16:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@chingor13@codecov-io@kolea2@sduskis@googlebot