Skip to content

Firestore: Cleanup unused dependencies - #5639

Merged
chingor13 merged 3 commits into
googleapis:masterfrom
athakor:cleanup-dependency-firestore-4383
Jul 30, 2019
Merged

Firestore: Cleanup unused dependencies#5639
chingor13 merged 3 commits into
googleapis:masterfrom
athakor:cleanup-dependency-firestore-4383

Conversation

@athakor

Copy link
Copy Markdown
Contributor

towards #4383

@athakor
athakor requested a review from a teamJuly 2, 2019 10:32
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2019
@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019
@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2019
@chingor13chingor13 self-assigned this Jul 30, 2019
@chingor13chingor13 changed the title Firestore : Cleanup dependencyFirestore: Cleanup unused dependenciesJul 30, 2019
@codecov

codecovBot commented Jul 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5639 into master will increase coverage by 0.55%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #5639 +/- ##
============================================
+ Coverage 46.71% 47.26% +0.55% - Complexity 24629 30217 +5588 
============================================
Files 2351 2456 +105 Lines 256127 305276 +49149 Branches 29325 34809 +5484 ============================================
+ Hits 119642 144284 +24642 - Misses 127565 151184 +23619 - Partials 8920 9808 +888
Impacted FilesCoverage ΔComplexity Δ
.../main/java/com/google/cloud/bigquery/BigQuery.java73.3% <0%> (-5.14%)0% <0%> (ø)
...va/com/google/cloud/storage/spi/v1/StorageRpc.java57.95% <0%> (-4.91%)0% <0%> (ø)
...google/cloud/compute/v1/InsertDiskHttpRequest.java19.77% <0%> (-4.66%)13% <0%> (+3%)
.../cloud/compute/v1/InsertRegionDiskHttpRequest.java19.77% <0%> (-4.66%)13% <0%> (+3%)
...pute/v1/InsertInstanceGroupManagerHttpRequest.java19.83% <0%> (-3.95%)11% <0%> (+2%)
...pute/v1/InsertGlobalForwardingRuleHttpRequest.java20% <0%> (-3.93%)11% <0%> (+2%)
...ud/compute/v1/InsertForwardingRuleHttpRequest.java20% <0%> (-3.93%)11% <0%> (+2%)
...1/InsertRegionInstanceGroupManagerHttpRequest.java19.91% <0%> (-3.87%)11% <0%> (+2%)
...oud/compute/v1/InsertInstanceGroupHttpRequest.java20.08% <0%> (-3.85%)12% <0%> (+3%)
...oud/compute/v1/InsertBackendBucketHttpRequest.java20.08% <0%> (-3.85%)12% <0%> (+3%)
... and 640 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3dd67e...4a8de7a. Read the comment docs.

@chingor13
chingor13 merged commit 54660bb into googleapis:masterJul 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@athakor@chingor13@googlebot@pmakani@yoshi-kokoro