Skip to content

Firestore: Fix float fields to accept in pojos. - #5642

Merged
BenWhitehead merged 2 commits into
googleapis:masterfrom
pmakani:api-firestore-5610
Jul 10, 2019
Merged

Firestore: Fix float fields to accept in pojos.#5642
BenWhitehead merged 2 commits into
googleapis:masterfrom
pmakani:api-firestore-5610

Conversation

@pmakani

Copy link
Copy Markdown

Fixes#5610

@pmakani
pmakani requested a review from a teamJuly 2, 2019 10:37
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2019
@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019
@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2019
@kolea2
kolea2 requested a review from BenWhiteheadJuly 10, 2019 18:35
@BenWhitehead
BenWhitehead merged commit ca4336e into googleapis:masterJul 10, 2019
@pmakani
pmakani deleted the api-firestore-5610 branch July 16, 2019 04:44
@JesseLovelaceJesseLovelace mentioned this pull request Jul 17, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firestore: set() does not accept pojos with float fields

5 participants

@pmakani@BenWhitehead@chingor13@googlebot@yoshi-kokoro