Skip to content

Os-login : Cleanup dependency - #5665

Merged
sduskis merged 3 commits into
googleapis:masterfrom
athakor:cleanup-dependency-os-login-4383
Jul 3, 2019
Merged

Os-login : Cleanup dependency#5665
sduskis merged 3 commits into
googleapis:masterfrom
athakor:cleanup-dependency-os-login-4383

Conversation

@athakor

Copy link
Copy Markdown
Contributor

towards #4383

@athakor
athakor requested a review from a teamJuly 3, 2019 11:15
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 3, 2019
@pmakanipmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019
@codecov

codecovBot commented Jul 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5665 into master will decrease coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #5665 +/- ##
===========================================
- Coverage 46.71% 46.42% -0.3% + Complexity 24644 24629 -15 
===========================================
Files 2351 2351 Lines 256127 256009 -118 Branches 29320 28536 -784 ===========================================
- Hits 119648 118850 -798 + Misses 127559 127479 -80 - Partials 8920 9680 +760
Impacted FilesCoverage ΔComplexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java48.95% <0%> (-6.46%)139% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java51.14% <0%> (-5.94%)55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java49.63% <0%> (-5.84%)35% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java50.41% <0%> (-5.79%)31% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java48.92% <0%> (-5.76%)35% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java50% <0%> (-5.74%)31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java49.04% <0%> (-5.74%)43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java48.57% <0%> (-5.72%)35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java48.1% <0%> (-5.7%)39% <0%> (ø)
...d/compute/v1/RegionInstanceGroupManagerClient.java48.81% <0%> (-5.69%)51% <0%> (ø)
... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1392cab...82e599e. Read the comment docs.

@sduskis
sduskis merged commit 44420e8 into googleapis:masterJul 3, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@athakor@sduskis@googlebot@pmakani@yoshi-kokoro