Uh oh!
There was an error while loading. Please reload this page.
Add VPCSC tests for cloud asset client lib - #5695
Merged
Merged
Conversation
The tests can be run inside or outside of VPC service perimeter. The input to the script should be the following environment variables. PROJECT_ID: a project that is inside the VPC perimeter. GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT: a project that is outside the VPC perimeter.
Codecov Report
@@ Coverage Diff @@## master #5695 +/- ##
============================================
- Coverage 46.71% 46.71% -0.01% + Complexity 24630 24629 -1
============================================
Files 2351 2351 Lines 256127 256127 Branches 29325 29325 ============================================
- Hits 119650 119648 -2 - Misses 127558 127559 +1 - Partials 8919 8920 +1
Continue to review full report at Codecov.
|
chingor13
approved these changes
Jul 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests can be run inside or outside of VPC service perimeter. The input to the script should be the following environment variables.
PROJECT_ID: a project that is inside the VPC perimeter.
GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT: a project that is outside the VPC perimeter.
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)