Skip to content

BigQuery: Implement missing list options - #5717

Merged
chingor13 merged 4 commits into
googleapis:masterfrom
shollyman:listoptions
Jul 12, 2019
Merged

BigQuery: Implement missing list options#5717
chingor13 merged 4 commits into
googleapis:masterfrom
shollyman:listoptions

Conversation

@shollyman

@shollymanshollyman commented Jul 10, 2019

Copy link
Copy Markdown
Contributor

Implements missing DatasetListOption and JobListOptions. This enables users of dataset list to do label-based filtration, and job listing now allows users to bound the job list based on a min/max creation time.

Fixes#5713
Fixes#5712

@shollyman
shollyman requested a review from a teamJuly 10, 2019 18:05
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2019
@codecov

codecovBot commented Jul 10, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5717 into master will decrease coverage by 0.7%.
The diff coverage is 33.33%.

Impacted file tree graph

@@ Coverage Diff @@## master #5717 +/- ##
============================================
- Coverage 47.08% 46.37% -0.71% + Complexity 24993 23557 -1436 
============================================
Files 2382 2382 Lines 259279 254103 -5176 Branches 29369 29167 -202 ============================================
- Hits 122074 117833 -4241 + Misses 128262 127472 -790 + Partials 8943 8798 -145
Impacted FilesCoverage ΔComplexity Δ
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java6.08% <0%> (-0.03%)2 <0> (ø)
.../main/java/com/google/cloud/bigquery/BigQuery.java77.05% <0%> (-1.39%)0 <0> (ø)
.../com/google/cloud/bigquery/spi/v2/BigQueryRpc.java80.95% <100%> (+3.17%)0 <0> (ø)⬇️
.../java/com/google/cloud/testing/CommandWrapper.java87.87% <0%> (-9.1%)13% <0%> (ø)
.../cloud/datastore/testing/LocalDatastoreHelper.java80.59% <0%> (-4.48%)17% <0%> (ø)
...in/java/com/google/cloud/storage/StorageBatch.java88% <0%> (-4%)13% <0%> (ø)
...n/java/com/google/cloud/firestore/WriteResult.java46.15% <0%> (-3.85%)4% <0%> (ø)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...age/contrib/nio/SeekableByteChannelPrefetcher.java63.12% <0%> (-3.13%)21% <0%> (-2%)
... and 649 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da86687...1eb562e. Read the comment docs.

@chingor13chingor13 changed the title bigquery: implement missing list optionsBigQuery: Implement missing list optionsJul 11, 2019
@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bigquery: label filtration on datasets bigquery: implement missing JobListOption filters

5 participants

@shollyman@chingor13@steffnay@googlebot@yoshi-kokoro