Skip to content

Remove fallback for yoshi-java - #5718

Merged
chingor13 merged 1 commit into
masterfrom
chingor13-patch-1
Jul 11, 2019
Merged

Remove fallback for yoshi-java#5718
chingor13 merged 1 commit into
masterfrom
chingor13-patch-1

Conversation

@chingor13

Copy link
Copy Markdown
Contributor

This is clogging notifications and we will have a better solution for notifying

This is clogging notifications and we will have a better solution for notifying
@chingor13
chingor13 requested a review from a teamJuly 10, 2019 18:29
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2019
@codecov

codecovBot commented Jul 10, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5718 into master will increase coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #5718 +/- ##
============================================
+ Coverage 46.69% 47.08% +0.38% - Complexity 23559 24993 +1434 
============================================
Files 2382 2382 Lines 254149 259279 +5130 Branches 29220 29369 +149 ============================================
+ Hits 118682 122073 +3391 - Misses 127433 128263 +830 - Partials 8034 8943 +909
Impacted FilesCoverage ΔComplexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java55.4% <0%> (-7.84%)139% <0%> (+34%)
...ava/com/google/cloud/compute/v1/ProjectClient.java57.07% <0%> (-6.99%)55% <0%> (+13%)
...va/com/google/cloud/compute/v1/SnapshotClient.java55.73% <0%> (-6.88%)31% <0%> (+7%)
...oogle/cloud/kms/v1/KeyManagementServiceClient.java62.88% <0%> (-6.84%)103% <0%> (+25%)
...a/com/google/cloud/compute/v1/NodeGroupClient.java60.36% <0%> (-6.82%)51% <0%> (+12%)
.../com/google/cloud/compute/v1/SubnetworkClient.java60.36% <0%> (-6.82%)51% <0%> (+12%)
...d/compute/v1/RegionInstanceGroupManagerClient.java54.5% <0%> (-6.79%)51% <0%> (+12%)
.../com/google/cloud/compute/v1/TargetPoolClient.java57.07% <0%> (-6.73%)47% <0%> (+11%)
.../google/cloud/compute/v1/TargetSslProxyClient.java54.28% <0%> (-6.69%)35% <0%> (+8%)
...e/cloud/compute/v1/InstanceGroupManagerClient.java57.32% <0%> (-6.66%)55% <0%> (+13%)
... and 620 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b91bbd...917889e. Read the comment docs.

@chingor13
chingor13 merged commit f800a9b into masterJul 11, 2019
@chingor13
chingor13 deleted the chingor13-patch-1 branch July 11, 2019 15:23
@JesseLovelaceJesseLovelace mentioned this pull request Jul 17, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13@kolea2@googlebot