Storage: Fix locationType field is added in bucket

[abhinav-qlogic]

Fixes#5442

Due to LocationType is a read-only field, So Have not added test case specific for dual-region or region locationType.

[codecov]

Codecov Report

Merging #5725 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #5725 +/- ##
============================================
+ Coverage 47.08% 47.09% +0.01% - Complexity 24995 25066 +71 
============================================
Files 2382 2389 +7 Lines 259281 259754 +473 Branches 29370 29406 +36 ============================================
+ Hits 122075 122331 +256 - Misses 128263 128462 +199 - Partials 8943 8961 +18

Impacted Files	Coverage Δ	Complexity Δ
...src/main/java/com/google/cloud/storage/Bucket.java	81.81% <100%> (+0.13%)	34 <0> (ø)	⬇️
...main/java/com/google/cloud/storage/BucketInfo.java	84.86% <100%> (+0.26%)	81 <1> (+3)	⬆️
...n/java/com/google/cloud/bigquery/BigQueryImpl.java	66.78% <0%> (-13.22%)	57% <0%> (ø)
...e/cloud/bigquery/testing/RemoteBigQueryHelper.java	61.4% <0%> (-1.1%)	6% <0%> (ø)
.../main/java/com/google/cloud/bigquery/BigQuery.java	77.55% <0%> (-0.9%)	0% <0%> (ø)
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java	5.23% <0%> (-0.87%)	2% <0%> (ø)
...gle/cloud/bigtable/data/v2/BigtableDataClient.java	89.58% <0%> (ø)	32% <0%> (ø)	⬇️
...bigtable/admin/v2/BigtableInstanceAdminClient.java	99.13% <0%> (ø)	44% <0%> (ø)	⬇️
...ud/bigtable/admin/v2/BigtableTableAdminClient.java	80% <0%> (ø)	27% <0%> (ø)	⬇️
...main/java/com/google/cloud/bigquery/RoutineId.java	76.92% <0%> (ø)	13% <0%> (?)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6a85b...50c2d21. Read the comment docs.

[frankyn]

I think this should be a private setLocationType due to read-only.

[frankyn]

Private here as well.

[damienlog]

Duplicate of #

[frankyn]

I

…

On Tue, Jul 16, 2019, 7:47 PM damieniver ***@***.***> wrote: ***@***.**** approved this pull request. Duplicate of # — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5725?email_source=notifications&email_token=AAORXQESB2OS2GNWGTJHKITP72B45A5CNFSM4IAWUYYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6U27RQ#pullrequestreview-262778822>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAORXQHD7A2D2QAMBHLHDR3P72B45ANCNFSM4IAWUYYA> .