Skip to content

Bigtable: Update integration tests to use the bundled emulator - #5769

Merged
igorbernstein2 merged 2 commits into
googleapis:masterfrom
igorbernstein2:bundled-emulator
Jul 19, 2019
Merged

Bigtable: Update integration tests to use the bundled emulator#5769
igorbernstein2 merged 2 commits into
googleapis:masterfrom
igorbernstein2:bundled-emulator

Conversation

@igorbernstein2

Copy link
Copy Markdown
Contributor

Also update the emulator bundler to download artifacts in parallel

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

Also update the emulator bundler to download artifacts in parallel
@igorbernstein2igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label Jul 18, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 18, 2019
@codecov

codecovBot commented Jul 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5769 into master will increase coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #5769 +/- ##
============================================
+ Coverage 46.5% 47.17% +0.67% - Complexity 23679 25115 +1436 
============================================
Files 2389 2389 Lines 254581 259836 +5255 Branches 28482 29422 +940 ============================================
+ Hits 118385 122586 +4201 - Misses 127412 128320 +908 - Partials 8784 8930 +146
Impacted FilesCoverage ΔComplexity Δ
...re/src/main/java/com/google/cloud/BaseService.java55.55% <0%> (-6.95%)2% <0%> (ø)
...re/src/main/java/com/google/cloud/RetryHelper.java50% <0%> (-3.85%)2% <0%> (ø)
...le/cloud/compute/deprecated/DeprecationStatus.java88.63% <0%> (-3.13%)20% <0%> (ø)
...m/google/cloud/tasks/v2beta3/CloudTasksClient.java57.43% <0%> (-2.68%)67% <0%> (+16%)
...va/com/google/cloud/tasks/v2/CloudTasksClient.java57.43% <0%> (-2.68%)67% <0%> (+16%)
...m/google/cloud/tasks/v2beta2/CloudTasksClient.java57.14% <0%> (-2.39%)79% <0%> (+19%)
...oogle/cloud/firestore/v1/FirestoreAdminClient.java59.84% <0%> (-2.23%)38% <0%> (+8%)
.../cloud/scheduler/v1beta1/CloudSchedulerClient.java55% <0%> (-2.15%)35% <0%> (+8%)
...oogle/cloud/scheduler/v1/CloudSchedulerClient.java55% <0%> (-2.15%)35% <0%> (+8%)
...gle/cloud/bigtable/data/v2/BigtableDataClient.java89.58% <0%> (-1.91%)32% <0%> (ø)
... and 646 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187fd3d...6ec8452. Read the comment docs.

Comment threadTESTING.md
target environment can be selected via the `bigtable.env` system property. By default it is set to
`emulator` and the other option is `prod`.

To use the `emulator` environment, please install the gcloud sdk and use it to install the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add these instructions to the emulator package?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, these instructions are for running the tests. The emulator package has instructions focusing on how a customer can use the emulator for their own tests:

https://github.com/googleapis/google-cloud-java/tree/master/google-cloud-testing/google-cloud-bigtable-emulator

@igorbernstein2

Copy link
Copy Markdown
ContributorAuthor

Thanks for reviewing!

@igorbernstein2
igorbernstein2 merged commit 4a95f17 into googleapis:masterJul 19, 2019
@igorbernstein2
igorbernstein2 deleted the bundled-emulator branch July 19, 2019 03:16
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
…eapis#5769)
* Bigtable: Update integration tests to use the bundled emulator
Also update the emulator bundler to download artifacts in parallel
* reformat
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2@kolea2@googlebot