Skip to content

Bigtable: Refactor TableAdmin tests to run against the emulator - #5795

Merged
igorbernstein2 merged 5 commits into
googleapis:masterfrom
igorbernstein2:table-admin-emulator
Aug 26, 2019
Merged

Bigtable: Refactor TableAdmin tests to run against the emulator#5795
igorbernstein2 merged 5 commits into
googleapis:masterfrom
igorbernstein2:table-admin-emulator

Conversation

@igorbernstein2

@igorbernstein2igorbernstein2 commented Jul 20, 2019

Copy link
Copy Markdown
Contributor
  • Share environment selector between admin & data
  • Stop data clean up and rely on garbage collection instead
  • extract table admin table clean up to a teardown function
  • remove cleanup responsibilities from env impls

To make reviewing easier, I would recommend to "Hide whitespace changes" in the diff

@igorbernstein2igorbernstein2 added the api: bigtable Issues related to the Bigtable API. label Jul 20, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2019
@igorbernstein2igorbernstein2 changed the title Bigtable: Refactor TableAdmin tests to run against the emulator [WIP]Bigtable: Refactor TableAdmin tests to run against the emulatorAug 22, 2019
@codecov

codecovBot commented Aug 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5795 into master will decrease coverage by 1.31%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #5795 +/- ##
============================================
- Coverage 47.38% 46.07% -1.32% + Complexity 27182 24189 -2993 
============================================
Files 2523 2456 -67 Lines 274600 262222 -12378 Branches 31383 30362 -1021 ============================================
- Hits 130125 120823 -9302 + Misses 134862 132287 -2575 + Partials 9613 9112 -501
Impacted FilesCoverage ΔComplexity Δ
.../java/com/google/cloud/testing/CommandWrapper.java87.87% <0%> (-9.1%)13% <0%> (ø)
.../cloud/datastore/testing/LocalDatastoreHelper.java80.59% <0%> (-4.48%)17% <0%> (ø)
...in/java/com/google/cloud/storage/StorageBatch.java88% <0%> (-4%)13% <0%> (ø)
...n/java/com/google/cloud/firestore/WriteResult.java46.15% <0%> (-3.85%)4% <0%> (ø)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...gle/cloud/storage/testing/RemoteStorageHelper.java61.98% <0%> (-3.06%)9% <0%> (ø)
...s/src/main/java/com/google/cloud/dns/DnsBatch.java87.87% <0%> (-3.04%)20% <0%> (ø)
...ud/bigtable/data/v2/stub/BigtableStubSettings.java81.61% <0%> (-2.96%)14% <0%> (ø)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
... and 900 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5826adf...0d7a5f0. Read the comment docs.

@igorbernstein2
igorbernstein2 marked this pull request as ready for review August 22, 2019 16:34
@igorbernstein2
igorbernstein2 merged commit c8abea1 into googleapis:masterAug 26, 2019
@igorbernstein2
igorbernstein2 deleted the table-admin-emulator branch August 26, 2019 19:50
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
…leapis#5795)
* Bigtable: allow integration test helpers to be shared by data & admin apis
* Allow test environment to be inspected
* Run most of table admin tests in emulator
* fix cleanup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2@kolea2@googlebot