Uh oh!
There was an error while loading. Please reload this page.
Bigtable: Refactor TableAdmin tests to run against the emulator - #5795
Merged
igorbernstein2 merged 5 commits intoAug 26, 2019
Merged
Conversation
igorbernstein2force-pushed
the
table-admin-emulator
branch
from
August 22, 2019 16:33
d81c1e0 to
0d7a5f0CompareCodecov Report
@@ Coverage Diff @@## master #5795 +/- ##
============================================
- Coverage 47.38% 46.07% -1.32% + Complexity 27182 24189 -2993
============================================
Files 2523 2456 -67 Lines 274600 262222 -12378 Branches 31383 30362 -1021 ============================================
- Hits 130125 120823 -9302 + Misses 134862 132287 -2575 + Partials 9613 9112 -501
Continue to review full report at Codecov.
|
igorbernstein2
marked this pull request as ready for review
August 22, 2019 16:34
kolea2
reviewed
Aug 26, 2019
Uh oh!
There was an error while loading. Please reload this page.
kolea2
approved these changes
Aug 26, 2019
benjaminp pushed a commit
to benjaminp/google-cloud-java
that referenced
this pull request
Jul 13, 2026
…leapis#5795) * Bigtable: allow integration test helpers to be shared by data & admin apis * Allow test environment to be inspected * Run most of table admin tests in emulator * fix cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make reviewing easier, I would recommend to "Hide whitespace changes" in the diff