Uh oh!
There was an error while loading. Please reload this page.
spanner-jdbc: Step 01 - Create jdbc project - #5805
Conversation
kolea2
left a comment
There was a problem hiding this comment.
LGTM but please also add to versions.txt (this will automatically increment the version number on releases).
Codecov Report
@@ Coverage Diff @@## spanner-jdbc #5805 +/- ##
==================================================
- Coverage 46.79% 46.11% -0.68% + Complexity 25648 24187 -1461
==================================================
Files 2456 2456 Lines 267593 262236 -5357 Branches 30564 29602 -962 ==================================================
- Hits 125228 120943 -4285 + Misses 133106 132179 -927 + Partials 9259 9114 -145
Continue to review full report at Codecov.
|
olavloite
commented
Jul 23, 2019
Added to versions.txt. |
| @@ -0,0 +1,124 @@ | |||
| #JDBC driver for Google Cloud Spanner | |||
There was a problem hiding this comment.
Sorry for missing this - you can address this in the next commit, but this needs a space between the # and JDBC. Also, please capitalize Driver
* create jdbc project * added spanner-jdbc to versions
Step 1: Create the project folder, pom and readme for the open source JDBC driver.