Skip to content

spanner-jdbc: Step 01 - Create jdbc project - #5805

Merged
olavloite merged 2 commits into
googleapis:spanner-jdbcfrom
olavloite:spanner-jdbc-01-create-project
Jul 23, 2019
Merged

spanner-jdbc: Step 01 - Create jdbc project#5805
olavloite merged 2 commits into
googleapis:spanner-jdbcfrom
olavloite:spanner-jdbc-01-create-project

Conversation

@olavloite

@olavloiteolavloite commented Jul 23, 2019

Copy link
Copy Markdown
Contributor

Step 1: Create the project folder, pom and readme for the open source JDBC driver.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2019
@olavloiteolavloite changed the title spanner-jdbc: Step 1 - Create jdbc projectspanner-jdbc: Step 01 - Create jdbc projectJul 23, 2019
@olavloite
olavloite marked this pull request as ready for review July 23, 2019 11:48
@olavloite
olavloite requested a review from kolea2July 23, 2019 11:49

@kolea2kolea2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please also add to versions.txt (this will automatically increment the version number on releases).

@kolea2kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 23, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2019
@codecov

codecovBot commented Jul 23, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5805 into spanner-jdbc will decrease coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## spanner-jdbc #5805 +/- ##
==================================================
- Coverage 46.79% 46.11% -0.68% + Complexity 25648 24187 -1461 
==================================================
Files 2456 2456 Lines 267593 262236 -5357 Branches 30564 29602 -962 ==================================================
- Hits 125228 120943 -4285 + Misses 133106 132179 -927 + Partials 9259 9114 -145
Impacted FilesCoverage ΔComplexity Δ
.../java/com/google/cloud/testing/CommandWrapper.java87.87% <0%> (-9.1%)13% <0%> (ø)
.../cloud/datastore/testing/LocalDatastoreHelper.java80.59% <0%> (-4.48%)17% <0%> (ø)
...in/java/com/google/cloud/storage/StorageBatch.java88% <0%> (-4%)13% <0%> (ø)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...age/contrib/nio/SeekableByteChannelPrefetcher.java63.12% <0%> (-3.13%)21% <0%> (-2%)
...gle/cloud/storage/testing/RemoteStorageHelper.java61.98% <0%> (-3.06%)9% <0%> (ø)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java48.57% <0%> (-2.78%)10% <0%> (-2%)
... and 654 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b56711...0e33c22. Read the comment docs.

@olavloite

Copy link
Copy Markdown
ContributorAuthor

LGTM but please also add to versions.txt (this will automatically increment the version number on releases).

Added to versions.txt.

@@ -0,0 +1,124 @@
#JDBC driver for Google Cloud Spanner

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this - you can address this in the next commit, but this needs a space between the # and JDBC. Also, please capitalize Driver

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, NP.

@olavloite
olavloite merged commit cafacf1 into googleapis:spanner-jdbcJul 23, 2019
olavloite added a commit to olavloite/google-cloud-java that referenced this pull request Aug 5, 2019
* create jdbc project
* added spanner-jdbc to versions
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@olavloite@kolea2@googlebot@yoshi-kokoro