Skip to content

spanner-jdbc: Step 04 - Public Cloud Spanner JDBC connection interface - #5808

Merged
olavloite merged 8 commits into
googleapis:spanner-jdbcfrom
olavloite:spanner-jdbc-04-jdbc-connection-interface
Jul 24, 2019
Merged

spanner-jdbc: Step 04 - Public Cloud Spanner JDBC connection interface#5808
olavloite merged 8 commits into
googleapis:spanner-jdbcfrom
olavloite:spanner-jdbc-04-jdbc-connection-interface

Conversation

@olavloite

Copy link
Copy Markdown
Contributor

Adds the public interface for JDBC connections returned by the Cloud Spanner JDBC driver.

@olavloite
olavloite requested a review from kolea2July 23, 2019 12:00
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2019
@olavloite
olavloiteforce-pushed the spanner-jdbc-04-jdbc-connection-interface branch from c71aab2 to 03eb964CompareJuly 23, 2019 15:26
@kolea2kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2019
@codecov

codecovBot commented Jul 24, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5808 into spanner-jdbc will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## spanner-jdbc #5808 +/- ##
==================================================
+ Coverage 46.12% 46.12% +<.01% 
Complexity 24189 24189 ==================================================
Files 2456 2456 Lines 262236 262236 Branches 29602 29602 ==================================================
+ Hits 120949 120952 +3 + Misses 132175 132173 -2 + Partials 9112 9111 -1
Impacted FilesCoverage ΔComplexity Δ
...gle/cloud/pubsub/v1/SequentialExecutorService.java90.8% <0%> (+3.44%)0% <0%> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae46c78...6d51db0. Read the comment docs.

1 similar comment
@codecov

codecovBot commented Jul 24, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5808 into spanner-jdbc will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## spanner-jdbc #5808 +/- ##
==================================================
+ Coverage 46.12% 46.12% +<.01% 
Complexity 24189 24189 ==================================================
Files 2456 2456 Lines 262236 262236 Branches 29602 29602 ==================================================
+ Hits 120949 120952 +3 + Misses 132175 132173 -2 + Partials 9112 9111 -1
Impacted FilesCoverage ΔComplexity Δ
...gle/cloud/pubsub/v1/SequentialExecutorService.java90.8% <0%> (+3.44%)0% <0%> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae46c78...6d51db0. Read the comment docs.

@kolea2

Copy link
Copy Markdown
Contributor

Can you please rebase this? Thanks!

@olavloite
olavloite merged commit edf686c into googleapis:spanner-jdbcJul 24, 2019
olavloite added a commit to olavloite/google-cloud-java that referenced this pull request Aug 5, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@olavloite@kolea2@googlebot@yoshi-kokoro