Uh oh!
There was an error while loading. Please reload this page.
Remove JobInfo hierarchy, add JobConfiguration hierarchy - #584
Conversation
e0a6fec to
84402acCompare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
aozarov
commented
Jan 26, 2016
Done withe the review. looks good. Main comment (as discussed verbally) is the suggestion to make JobConfiguration interface an abstract class (and use package scope methods to set or get from pb). |
022ad08 to
d170550Compared170550 to
a2c8b39Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
aozarov
commented
Jan 29, 2016
Looks great! Do you plan to do the same for BaseTableInfo ? BTW, looks like BigQueryException has 2 unused import statements. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This PR removes
JobInfohierarchy and replaces it with a hierarchy onJobConfiguration. This change is needed to make functionalJobextendJobInfo. Notes:CopyJobConfiguration,ExtractJobConfiguration,LoadJobConfigurationorQueryJobConfiguration) must be provided to create aJobInfoobject.LoadJobConfigurationalso extendsLoadConfigurationwhich is used for resumable uploadsJobConfigurationis an interface with only atype()method since configurations have no common data (this is also required to makeLoadJobConfigurationextendLoadConfiguration).