Skip to content

Remove JobInfo hierarchy, add JobConfiguration hierarchy - #584

Merged
aozarov merged 6 commits into
googleapis:masterfrom
mziccard:bigquery-hierachies
Jan 29, 2016
Merged

Remove JobInfo hierarchy, add JobConfiguration hierarchy#584
aozarov merged 6 commits into
googleapis:masterfrom
mziccard:bigquery-hierachies

Conversation

@mziccard

Copy link
Copy Markdown
Contributor

This PR removes JobInfo hierarchy and replaces it with a hierarchy on JobConfiguration. This change is needed to make functional Job extend JobInfo. Notes:

  • A configuration object (CopyJobConfiguration, ExtractJobConfiguration, LoadJobConfiguration or QueryJobConfiguration) must be provided to create a JobInfo object.
  • LoadJobConfiguration also extends LoadConfiguration which is used for resumable uploads
  • JobConfiguration is an interface with only a type() method since configurations have no common data (this is also required to make LoadJobConfiguration extend LoadConfiguration).

@mziccardmziccard added the api: bigquery Issues related to the BigQuery API. label Jan 26, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2016

This comment was marked as spam.

@aozarov

Copy link
Copy Markdown
Contributor

Done withe the review. looks good. Main comment (as discussed verbally) is the suggestion to make JobConfiguration interface an abstract class (and use package scope methods to set or get from pb).

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@aozarov

Copy link
Copy Markdown
Contributor

Looks great! Do you plan to do the same for BaseTableInfo ?

BTW, looks like BigQueryException has 2 unused import statements.

This comment was marked as spam.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mziccard@aozarov@ajkannan@googlebot