Skip to content

TextToSpeech: Fix #4595 update default inbound msg size to max - #5883

Merged
chingor13 merged 2 commits into
googleapis:masterfrom
ajaaym:fix_4595
Jul 30, 2019
Merged

TextToSpeech: Fix #4595 update default inbound msg size to max#5883
chingor13 merged 2 commits into
googleapis:masterfrom
ajaaym:fix_4595

Conversation

@ajaaym

Copy link
Copy Markdown
Contributor

Fixes#4595

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2019
@codecov

codecovBot commented Jul 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5883 into master will decrease coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #5883 +/- ##
============================================
- Coverage 46.79% 46.41% -0.38% + Complexity 25648 24189 -1459 
============================================
Files 2456 2456 Lines 267593 262358 -5235 Branches 30564 30414 -150 ============================================
- Hits 125225 121779 -3446 + Misses 133109 132251 -858 + Partials 9259 8328 -931
Impacted FilesCoverage ΔComplexity Δ
...m/google/cloud/vision/v1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java48.57% <0%> (-2.78%)10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java48.57% <0%> (-2.78%)10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java63.41% <0%> (-2.5%)12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java55.88% <0%> (-2.46%)9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java55.88% <0%> (-2.46%)9% <0%> (-2%)
...oogle/cloud/language/v1/LanguageServiceClient.java79.16% <0%> (-2.32%)26% <0%> (-9%)
... and 673 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123d374...429208a. Read the comment docs.

@chingor13chingor13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these synth replacements, we want them to be mostly temporary and fix the issue upstream.

For this one, we should file a feature request to https://github.com/googleapis/gapic-generator to add a gapic config for the maxInboundMessageSize default and add a link to that bug in a comment here.

@chingor13
chingor13 merged commit 3626b89 into googleapis:masterJul 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TextToSpeech: RESOURCE_EXAUSTED: gRPC message exceeds maximum size

3 participants

@ajaaym@chingor13@googlebot