Skip to content

spanner-jdbc: Step 27 - JdbcDriver - #5912

Merged
olavloite merged 3 commits into
googleapis:spanner-jdbcfrom
olavloite:spanner-jdbc-27-jdbc-driver
Jul 31, 2019
Merged

spanner-jdbc: Step 27 - JdbcDriver#5912
olavloite merged 3 commits into
googleapis:spanner-jdbcfrom
olavloite:spanner-jdbc-27-jdbc-driver

Conversation

@olavloite

@olavloiteolavloite commented Jul 29, 2019

Copy link
Copy Markdown
Contributor

Adds the actual JDBC Driver, including the service registration file for the driver.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2019
@olavloite
olavloite requested a review from kolea2July 29, 2019 10:09
kolea2
kolea2 suggested changes Jul 29, 2019
View reviewed changes
Comment thread...ib/google-cloud-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/JdbcDriverTest.java Outdated
Comment thread...cloud-contrib/google-cloud-spanner-jdbc/src/main/resources/META-INF/services/java.sql.Driver
@olavloite
olavloiteforce-pushed the spanner-jdbc-27-jdbc-driver branch from 68038e2 to 0dd1027CompareJuly 30, 2019 08:54
@olavloite
olavloite requested a review from kolea2July 30, 2019 08:54
kolea2
kolea2 reviewed Jul 30, 2019
View reviewed changes
Comment thread...ontrib/google-cloud-spanner-jdbc/src/main/java/com/google/cloud/spanner/jdbc/JdbcDriver.java
}
private static JdbcDriver registeredDriver;

static void register() throws SQLException {

@kolea2kolea2Jul 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one last question. How come this is different than the class loading done in JdbcDataSource?

@olavloiteolavloiteJul 30, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JdbcDataSource is not responsible for registering the JDBC driver. That is the responsibility of the driver itself, and is done automatically when the driver class (JdbcDriver) is loaded. In most newer environments this is done automatically thanks to the service registration in META-INF/services/java.sqlDriver. The JdbcDataSource does a manual load of the driver class to be 100% certain that the driver is loaded and registered, although in most cases it will be redundant.

@olavloite
olavloite merged commit 666efd5 into googleapis:spanner-jdbcJul 31, 2019
olavloite added a commit to olavloite/google-cloud-java that referenced this pull request Aug 5, 2019
@olavloite
spanner-jdbc: Step 27 - JdbcDriver (googleapis#5912)
7a9d2a6
* add JdbcDriver
* add jdbc DataSource implementation
* removed information from test connection url
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kolea2kolea2kolea2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite@kolea2@googlebot