Uh oh!
There was an error while loading. Please reload this page.
Firestore: Add @Deprecated annotation to getCollections - #5916
Conversation
f6a9c43 to
497a039CompareBenWhitehead
commented
Jul 29, 2019
I'm okay with the additional detail, but the javadocs don't seem to provide an alternative of how the users is supposed to be able to do this sort of operation. Do you know what the replacement is that we could refer to? |
schmidt-sebastian
commented
Jul 29, 2019
The JavaDoc's deprecated comments do say to use |
BenWhitehead
commented
Jul 29, 2019
Ah, so it does my mistake. LGTM. |
BenWhitehead
commented
Jul 29, 2019
Actually, can we change the deprecation javadocs to use this format: Instead of the back-ticks. This will make the link clickable in the javadocs if we do it. |
schmidt-sebastian
commented
Jul 29, 2019
Updated the JavaDoc to use the links as suggested. |
Codecov Report
@@ Coverage Diff @@## master #5916 +/- ##
============================================
- Coverage 46.79% 46.79% -0.01% - Complexity 25648 25663 +15
============================================
Files 2456 2456 Lines 267593 267593 Branches 30564 30559 -5 ============================================
- Hits 125229 125228 -1 - Misses 133105 133106 +1
Partials 9259 9259
Continue to review full report at Codecov.
|
These methods are deprecated as per the JavaDoc but we should probably use an Annotation as well.