Skip to content

Move setClientLibToken to ServiceOptions. - #5959

Merged
olavloite merged 3 commits into
googleapis:spanner-jdbcfrom
kolea2:client-lib-token
Aug 5, 2019
Merged

Move setClientLibToken to ServiceOptions.#5959
olavloite merged 3 commits into
googleapis:spanner-jdbcfrom
kolea2:client-lib-token

Conversation

@kolea2

Copy link
Copy Markdown
Contributor

After discussion with @chingor13, moving this API to ServiceOptions to use more broadly.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2019
@chingor13

Copy link
Copy Markdown
Contributor

cc @dazuma

@codecov

codecovBot commented Aug 1, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5959 into spanner-jdbc will decrease coverage by 0.77%.
The diff coverage is 33.33%.

Impacted file tree graph

@@ Coverage Diff @@## spanner-jdbc #5959 +/- ##
==================================================
- Coverage 47.33% 46.56% -0.78% + Complexity 27091 25581 -1510 
==================================================
Files 2516 2516 Lines 273453 268014 -5439 Branches 31350 30337 -1013 ==================================================
- Hits 129442 124798 -4644 + Misses 134405 133763 -642 + Partials 9606 9453 -153
Impacted FilesCoverage ΔComplexity Δ
...src/main/java/com/google/cloud/ServiceOptions.java40.33% <33.33%> (+0.07%)29 <0> (ø)⬇️
...va/com/google/cloud/spanner/jdbc/FailedUpdate.java0% <0%> (-86.37%)0% <0%> (-2%)
...m/google/cloud/spanner/jdbc/ChecksumResultSet.java37.73% <0%> (-52.21%)4% <0%> (-4%)
...ava/com/google/cloud/spanner/jdbc/FailedQuery.java0% <0%> (-37.04%)0% <0%> (-1%)
...oogle/cloud/spanner/jdbc/RetriableBatchUpdate.java0% <0%> (-35%)0% <0%> (-1%)
...m/google/cloud/spanner/jdbc/FailedBatchUpdate.java0% <0%> (-29.63%)0% <0%> (-1%)
...oogle/cloud/spanner/jdbc/ReadWriteTransaction.java52.54% <0%> (-27.12%)36% <0%> (-15%)
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java68.18% <0%> (-18.7%)34% <0%> (-5%)
...le/cloud/spanner/jdbc/JdbcSqlExceptionFactory.java31.88% <0%> (-13.84%)5% <0%> (-2%)
...com/google/cloud/spanner/jdbc/RetriableUpdate.java80% <0%> (-10%)3% <0%> (ø)
... and 852 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1905f8...c97de8d. Read the comment docs.

@olavloite
olavloite merged commit b4ef635 into googleapis:spanner-jdbcAug 5, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kolea2@chingor13@olavloite@googlebot