Skip to content

Small refactoring to signUrl code. - #6078

Merged
JesseLovelace merged 2 commits into
googleapis:masterfrom
houglum:signurl-refactor-before-virtual-option
Aug 26, 2019
Merged

Small refactoring to signUrl code.#6078
JesseLovelace merged 2 commits into
googleapis:masterfrom
houglum:signurl-refactor-before-virtual-option

Conversation

@houglum

Copy link
Copy Markdown

This commit attempts to refactor some of the functionality in signUrl
such that it's easier to follow and will be easier to add functionality
for generating virtual hosted-style signed URLs. The branch containing
future changes is shown below; this commit is mostly trying to separate
refactoring from new functionality being added:
https://github.com/houglum/google-cloud-java/compare/6e0f6ef..b52205b

This commit also contains a couple of small doc tweaks.

This commit attempts to refactor some of the functionality in signUrl
such that it's easier to follow and will be easier to add functionality
for generating virtual hosted-style signed URLs. The branch containing
the changes is shown below; this commit is mostly trying to separate
refactoring from new functionality being added:
https://github.com/houglum/google-cloud-java/compare/6e0f6ef..b52205b
This commit also contains a couple of small doc tweaks.
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 14, 2019
@houglum

Copy link
Copy Markdown
Author

@frankyn FYI, this is to help facilitate adding the signed URL functionality we talked about last week

@codecov

codecovBot commented Aug 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6078 into master will increase coverage by 0.65%.
The diff coverage is 96%.

Impacted file tree graph

@@ Coverage Diff @@## master #6078 +/- ##
============================================
+ Coverage 46.73% 47.39% +0.65% - Complexity 25715 27183 +1468 
============================================
Files 2523 2523 Lines 269162 274588 +5426 Branches 30364 31380 +1016 ============================================
+ Hits 125789 130131 +4342 - Misses 133910 134850 +940 - Partials 9463 9607 +144
Impacted FilesCoverage ΔComplexity Δ
...rc/main/java/com/google/cloud/storage/Storage.java79.72% <100%> (ø)0 <0> (ø)⬇️
...ain/java/com/google/cloud/storage/StorageImpl.java78.37% <95.65%> (+0.63%)100 <0> (+2)⬆️
...re/src/main/java/com/google/cloud/BaseService.java55.55% <0%> (-6.95%)2% <0%> (ø)
...re/src/main/java/com/google/cloud/RetryHelper.java50% <0%> (-3.85%)2% <0%> (ø)
...le/cloud/compute/deprecated/DeprecationStatus.java88.63% <0%> (-3.13%)20% <0%> (ø)
...m/google/cloud/tasks/v2beta3/CloudTasksClient.java57.43% <0%> (-2.68%)67% <0%> (+16%)
...va/com/google/cloud/tasks/v2/CloudTasksClient.java57.43% <0%> (-2.68%)67% <0%> (+16%)
...m/google/cloud/tasks/v2beta2/CloudTasksClient.java57.14% <0%> (-2.39%)79% <0%> (+19%)
...oogle/cloud/firestore/v1/FirestoreAdminClient.java59.84% <0%> (-2.23%)38% <0%> (+8%)
.../cloud/scheduler/v1beta1/CloudSchedulerClient.java55% <0%> (-2.15%)35% <0%> (+8%)
... and 673 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b0d5ce...ae8e312. Read the comment docs.

@houglum

Copy link
Copy Markdown
Author

Only presubmit failure was from the linter; I ran mvn com.coveo:fmt-maven-plugin:format and sent a follow-up commit.

@houglum

Copy link
Copy Markdown
Author

@JesseLovelace friendly ping

I've got a couple more PRs queued up after this one (those are more substantial and introduce additional functionality), so reviewing this would unblock me :)

@JesseLovelace
JesseLovelace merged commit e2fc2c3 into googleapis:masterAug 26, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@houglum@JesseLovelace@googlebot