Uh oh!
There was an error while loading. Please reload this page.
Small refactoring to signUrl code. - #6078
Conversation
This commit attempts to refactor some of the functionality in signUrl such that it's easier to follow and will be easier to add functionality for generating virtual hosted-style signed URLs. The branch containing the changes is shown below; this commit is mostly trying to separate refactoring from new functionality being added: https://github.com/houglum/google-cloud-java/compare/6e0f6ef..b52205b This commit also contains a couple of small doc tweaks.
houglum
commented
Aug 14, 2019
@frankyn FYI, this is to help facilitate adding the signed URL functionality we talked about last week |
Codecov Report
@@ Coverage Diff @@## master #6078 +/- ##
============================================
+ Coverage 46.73% 47.39% +0.65% - Complexity 25715 27183 +1468
============================================
Files 2523 2523 Lines 269162 274588 +5426 Branches 30364 31380 +1016 ============================================
+ Hits 125789 130131 +4342 - Misses 133910 134850 +940 - Partials 9463 9607 +144
Continue to review full report at Codecov.
|
houglum
commented
Aug 16, 2019
Only presubmit failure was from the linter; I ran |
houglum
commented
Aug 26, 2019
@JesseLovelace friendly ping I've got a couple more PRs queued up after this one (those are more substantial and introduce additional functionality), so reviewing this would unblock me :) |
This commit attempts to refactor some of the functionality in signUrl
such that it's easier to follow and will be easier to add functionality
for generating virtual hosted-style signed URLs. The branch containing
future changes is shown below; this commit is mostly trying to separate
refactoring from new functionality being added:
https://github.com/houglum/google-cloud-java/compare/6e0f6ef..b52205b
This commit also contains a couple of small doc tweaks.