Skip to content

Dialogflow: Add ContextManagementSmokeTest - #6086

Merged
chingor13 merged 3 commits into
googleapis:masterfrom
chingor13:dialogflow-beta
Aug 26, 2019
Merged

Dialogflow: Add ContextManagementSmokeTest#6086
chingor13 merged 3 commits into
googleapis:masterfrom
chingor13:dialogflow-beta

Conversation

@chingor13

@chingor13chingor13 commented Aug 15, 2019

Copy link
Copy Markdown
Contributor

Towards #5938

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 15, 2019
@codecov

codecovBot commented Aug 15, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #6086 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #6086 +/- ##
============================================
- Coverage 47.38% 47.38% -0.01% + Complexity 27182 27180 -2 
============================================
Files 2523 2523 Lines 274581 274581 Branches 31380 31380 ============================================
- Hits 130123 130120 -3 - Misses 134850 134851 +1 - Partials 9608 9610 +2
Impacted FilesCoverage ΔComplexity Δ
...able/gaxx/reframing/ReframingResponseObserver.java88.99% <0%> (-1.84%)29% <0%> (-1%)
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java86.87% <0%> (-0.91%)39% <0%> (-1%)
...ain/java/com/google/cloud/pubsub/v1/Publisher.java89.45% <0%> (+0.34%)40% <0%> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1daf76a...7c29d96. Read the comment docs.

@chingor13

chingor13 commented Aug 15, 2019

Copy link
Copy Markdown
ContributorAuthor

The coverage drop probably isn't right as this PR literally only adds tests.

@chingor13
chingor13 requested a review from kolea2August 21, 2019 19:00
@chingor13chingor13 changed the title Dialogflow: Add ContentManagementSmokeTestDialogflow: Add ContextManagementSmokeTestAug 21, 2019
@devtimlai

devtimlai commented Aug 26, 2019

Copy link
Copy Markdown

The change looks sensible. anything pending for merging the PR?

kolea2
kolea2 reviewed Aug 26, 2019
View reviewed changes
Comment thread...loud-dialogflow/src/test/java/com/google/cloud/dialogflow/v2/ContextManagementSmokeTest.java

public class ContextManagementSmokeTest {
private static final String PROJECT_ENV_NAME = "GOOGLE_CLOUD_PROJECT";
private static final String LEGACY_PROJECT_ENV_NAME = "GCLOUD_PROJECT";

@kolea2kolea2Aug 26, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to support a legacy name?

@chingor13chingor13Aug 26, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're still using that env variable :(

@chingor13
chingor13 merged commit 8a6deba into googleapis:masterAug 26, 2019
@chingor13
chingor13 deleted the dialogflow-beta branch August 26, 2019 22:24
@kolea2kolea2 mentioned this pull request Aug 28, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kolea2kolea2kolea2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chingor13@devtimlai@kolea2@googlebot