Uh oh!
There was an error while loading. Please reload this page.
spanner-jdbc: Allow empty or invalid env credentials - #6092
Closed
olavloite wants to merge 2 commits into
Closed
Conversation
ContributorAuthor
kolea2
suggested changes
Aug 16, 2019
| } catch (Exception e) { | ||
| // Ignore the error if the user did not set a credentials URL. | ||
| // The error is then caused by an invalid environment configuration | ||
| // and should not be thrown here. |
Contributor
There was a problem hiding this comment.
can we add a test that asserts the correct exception is thrown?
ContributorAuthor
There was a problem hiding this comment.
I've added a couple of test cases to cover this.
On environments with no or invalid application credentials, the JDBC driver would throw an IllegalArgumentException when a connection was being created without an explicit credentials URL included in the connection string.
olavloiteforce-pushed
the
spanner-jdbc-fix-tests-for-envs-with-invalid-or-no-app-credentials
branch
from
August 17, 2019 07:05
5415654 to
3f019ebCompareCodecov Report
@@ Coverage Diff @@## master #6092 +/- ##
============================================
+ Coverage 47.38% 47.38% +<.01%
Complexity 27180 27180 ============================================
Files 2523 2523 Lines 274580 274589 +9 Branches 31380 31381 +1 ============================================
+ Hits 130118 130126 +8
Misses 134852 134852 - Partials 9610 9611 +1
Continue to review full report at Codecov.
|
skuruppu
self-requested a review
August 23, 2019 01:34
olavloite
commented
Aug 23, 2019
ContributorAuthor
Abandoned. This should be fixed in the test cases rather than deferring the exception to a later moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On environments with no or invalid application credentials, the JDBC driver would throw an
IllegalArgumentExceptionwhen a connection was being created without an explicit credentials URL included in the connection string.Updates #6075