Skip to content

docs: update Pub/Sub publisher docstring example - #6100

Merged
chingor13 merged 2 commits into
masterfrom
anguillanneuf-patch-1
Aug 21, 2019
Merged

docs: update Pub/Sub publisher docstring example#6100
chingor13 merged 2 commits into
masterfrom
anguillanneuf-patch-1

Conversation

@anguillanneuf

@anguillanneufanguillanneuf commented Aug 16, 2019

Copy link
Copy Markdown
Contributor

Fixes#3920

Missed the docstring in a previous PR #4120 that addressed the same issue.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2019
@anguillanneufanguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2019
@anguillanneufanguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2019
@anguillanneufanguillanneuf changed the title docs: update docstring for ApiFutures.addCallback() in Pub/Subdocs: update Pub/Sub publisher docstring exampleAug 19, 2019
@anguillanneuf

Copy link
Copy Markdown
ContributorAuthor

@chingor13 Do you know why the test kept failing?

@chingor13

Copy link
Copy Markdown
Contributor

It looks like a flakey spanner JDBC test. @kolea2, @olavloite might know more.

@kolea2

Copy link
Copy Markdown
Contributor

Sorry about that, we're tracking #6075 to fix this. I've rerun the build.

@codecov

codecovBot commented Aug 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6100 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #6100 +/- ##
============================================
+ Coverage 47.38% 47.4% +0.01% - Complexity 27180 27228 +48 
============================================
Files 2523 2523 Lines 274580 274830 +250 Branches 31380 31391 +11 ============================================
+ Hits 130118 130289 +171 - Misses 134852 134928 +76 - Partials 9610 9613 +3
Impacted FilesCoverage ΔComplexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java89.11% <ø> (ø)40 <0> (ø)⬇️
...gtable/admin/v2/BigtableInstanceAdminSettings.java97.77% <0%> (-2.23%)11% <0%> (+5%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java60.56% <0%> (-1.44%)25% <0%> (+6%)
.../bigtable/admin/v2/BigtableTableAdminSettings.java73.25% <0%> (+1.51%)14% <0%> (+7%)⬆️
...e/cloud/bigtable/data/v2/BigtableDataSettings.java37.2% <0%> (+2.42%)4% <0%> (+1%)⬆️
...d/dialogflow/v2beta1/SessionEntityTypesClient.java64.77% <0%> (+4.99%)39% <0%> (+16%)⬆️
.../cloud/dialogflow/v2/SessionEntityTypesClient.java66.02% <0%> (+6.24%)36% <0%> (+13%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81aad64...7294775. Read the comment docs.

@chingor13
chingor13 merged commit 3909ebd into masterAug 21, 2019
@anguillanneuf
anguillanneuf deleted the anguillanneuf-patch-1 branch August 21, 2019 23:31
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
* update docstring for ApiFutures.addCallback()
* go back to 2016
meltsufin pushed a commit that referenced this pull request May 1, 2026
* update docstring for ApiFutures.addCallback()
* go back to 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pub/Sub: ApiFutures.addCallback() deprecated in code example

5 participants

@anguillanneuf@chingor13@kolea2@googlebot@yoshi-kokoro